[GitHub] [hudi] codope commented on a diff in pull request #6113: [HUDI-4400] Fix missing bloom filters in metadata table in non-partitioned table

[GitBox <gi...@apache.org>]

codope commented on code in PR #6113:
URL: https://github.com/apache/hudi/pull/6113#discussion_r923152896


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bloom/TestHoodieBloomIndex.java:
##########
@@ -428,7 +455,99 @@ public void testTagLocation(boolean rangePruning, boolean treeFiltering, boolean
 
   @ParameterizedTest(name = TEST_NAME_WITH_PARAMS)
   @MethodSource("configParams")
-  public void testCheckExists(boolean rangePruning, boolean treeFiltering, boolean bucketizedChecking) throws Exception {
+  public void testTagLocationOnNonpartitionedTable(
+      boolean rangePruning, boolean treeFiltering, boolean bucketizedChecking,
+      boolean useMetadataTable) throws Exception {
+    // We have some records to be tagged (two different partitions)
+    String rowKey1 = UUID.randomUUID().toString();

Review Comment:
   +1
   Would be good to do this for all tests.
   Just take the change in `FileSystemTestUtils` https://github.com/apache/hudi/pull/6049/files#diff-39cc6a706b7cad836c15caf1a61256c5f50d4ac8ea511de5a4a29f8deb3a2f6c
   ```
   public static final Random RANDOM = new Random(0xDEED);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org