You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Leader Ni (Created) (JIRA)" <ji...@apache.org> on 2011/12/06 11:43:40 UTC
[jira] [Created] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Add the feathre to zookeeper allow client limited.
--------------------------------------------------
Key: ZOOKEEPER-1320
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
Project: ZooKeeper
Issue Type: New Feature
Components: server
Affects Versions: 3.3.3
Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
Reporter: Leader Ni
Fix For: 3.3.5
Add the feathre to zookeeper so that administrator can set the list of ip that limited to connect zk server and connected client to operate data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Posted by "Leader Ni (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leader Ni updated ZOOKEEPER-1320:
---------------------------------
Attachment: ZOOKEEPER-1320-iplimited.patch
zookeeper-3.3.3.jar_iplimited
UserGuide-1320-iplimited.pdf
UserGuide-1320-iplimited.docx
Any problem，mail to nileader@gmail.com
How to use this feature:
1. Download ZOOKEEPER-1320-iplimited.patch, and patch it on you zookeeper server source code, and rebuild you project. Or you can download the zookeeper-3.3.3.jar_iplimited and rename it to zookeeper-3.3.3.jar.
2. Replace zookeeper-3.3.3.jar of %ZK_HOME%/
3. Start it.
4. Use ./zkCli.sh to connect to the server, and use commands as follow:
set /zookeeper/extends/skip_limited_ip false
set /zookeeper/extends/limited_ip 1.1.1.1,1.1.1.2,1.1.1.3
5. Use these command in runtime feel free, take effect within 10 seconds.
6. Note: Use comma with English state input method.
7. Enjoy.
1. 下载 ZOOKEEPER-1320-iplimited.patch，打到你的zk源代码上，然后重新build一次。或者可以直接zookeeper-3.3.3.jar_iplimited (这个是我在3.3.3-rc0基础上build的)，并重命名为zookeeper-3.3.3.jar。
2. 替换server上 %ZK_HOME%中的zookeeper-3.3.3.jar。
3. 启动zk。
4. 通过命令方式 ./zkCli.sh 连接zk，进行如下操作：
set /zookeeper/extends/skip_limited_ip false
set /zookeeper/extends/limited_ip 1.1.1.1,1.1.1.2,1.1.1.3
注意：不同ip之间用英文状态 , 隔开。以后可以随时执行以上命令，至多10s内生效。
> Add the feathre to zookeeper allow client limited.
> --------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Fix For: 3.3.5
>
> Attachments: UserGuide-1320-iplimited.docx, UserGuide-1320-iplimited.pdf, ZOOKEEPER-1320-iplimited.patch, zookeeper-3.3.3.jar_iplimited
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Posted by "Ted Dunning (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163662#comment-13163662 ]
Ted Dunning commented on ZOOKEEPER-1320:
----------------------------------------
This is already very easy to do with iptables. Is this really a feature that we need to implement in Zookeeper itself.
Also, if you want to implement this, it will be important to describe the feature in more detail and describe how you will test it.
> Add the feathre to zookeeper allow client limited.
> --------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Labels: client,server,limited,ipfilter
> Fix For: 3.3.5
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Posted by "Patrick Hunt (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1320:
---------------------------------------
Assignee: Leader Ni
> Add the feathre to zookeeper allow client limited.
> --------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Fix For: 3.3.5
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1320) Add the feature to zookeeper
allow client limitations by ip.
Posted by "Leader Ni (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leader Ni resolved ZOOKEEPER-1320.
----------------------------------
Resolution: Incomplete
> Add the feature to zookeeper allow client limitations by ip.
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Attachments: UserGuide-1320-iplimited.docx, UserGuide-1320-iplimited.pdf, ZOOKEEPER-1320-iplimited.patch, zookeeper-3.3.3.jar_iplimited
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1320) Add the feature to zookeeper
allow client limitations by ip.
Posted by "Camille Fournier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232081#comment-13232081 ]
Camille Fournier commented on ZOOKEEPER-1320:
---------------------------------------------
It doesn't look like we agree that this feature is necessary and it's not applying cleanly. I'm moving this out of patch available state until you get it into more review-ready shape.
> Add the feature to zookeeper allow client limitations by ip.
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Attachments: UserGuide-1320-iplimited.docx, UserGuide-1320-iplimited.pdf, ZOOKEEPER-1320-iplimited.patch, zookeeper-3.3.3.jar_iplimited
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Posted by "Ted Dunning (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164186#comment-13164186 ]
Ted Dunning commented on ZOOKEEPER-1320:
----------------------------------------
I would think that these sorts of commands would be better in the configuration file.
Also, how would you specify multiple subnets? Can this handle IPV4 and IPV4?
> Add the feathre to zookeeper allow client limited.
> --------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Fix For: 3.3.5
>
> Attachments: UserGuide-1320-iplimited.docx, UserGuide-1320-iplimited.pdf, ZOOKEEPER-1320-iplimited.patch, zookeeper-3.3.3.jar_iplimited
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1320) Add the feature to zookeeper
allow client limitations by ip.
Posted by "Patrick Hunt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1320:
------------------------------------
Fix Version/s: (was: 3.3.5)
Summary: Add the feature to zookeeper allow client limitations by ip. (was: Add the feathre to zookeeper allow client limited.)
> Add the feature to zookeeper allow client limitations by ip.
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Attachments: UserGuide-1320-iplimited.docx, UserGuide-1320-iplimited.pdf, ZOOKEEPER-1320-iplimited.patch, zookeeper-3.3.3.jar_iplimited
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163742#comment-13163742 ]
Patrick Hunt commented on ZOOKEEPER-1320:
-----------------------------------------
I agree with Ted, documenting further before you build will ease getting something committed rather than a lengthy patch update cycle.
For example how to ascertain if this can be configured (at runtime) or will it require restart to change, how will it be monitored, logged, etc... would all be useful details to capture. (saying you're not doing it is also a fine thing to document)
You could document on this jira or start a cwiki page if you like.
> Add the feathre to zookeeper allow client limited.
> --------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Fix For: 3.3.5
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Posted by "Ted Dunning (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Dunning updated ZOOKEEPER-1320:
-----------------------------------
Description: Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data. (was: Add the feathre to zookeeper so that administrator can set the list of ip that limited to connect zk server and connected client to operate data.)
> Add the feathre to zookeeper allow client limited.
> --------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Labels: client,server,limited,ipfilter
> Fix For: 3.3.5
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164869#comment-13164869 ]
Hadoop QA commented on ZOOKEEPER-1320:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506400/ZOOKEEPER-1320-iplimited.patch
against trunk revision 1208979.
-1 @author. The patch appears to contain 1 @author tags which the Zookeeper community has agreed to not allow in code contributions.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/810//console
This message is automatically generated.
> Add the feathre to zookeeper allow client limited.
> --------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Fix For: 3.3.5
>
> Attachments: UserGuide-1320-iplimited.docx, UserGuide-1320-iplimited.pdf, ZOOKEEPER-1320-iplimited.patch, zookeeper-3.3.3.jar_iplimited
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Posted by "Leader Ni (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164205#comment-13164205 ]
Leader Ni commented on ZOOKEEPER-1320:
--------------------------------------
1. Oh, Thanks. IPV4 and IPV6, I really did not think about it. I will try the difference.
2. I config the ip list on znode just want to support to set the ipList in runtime.
> Add the feathre to zookeeper allow client limited.
> --------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Fix For: 3.3.5
>
> Attachments: UserGuide-1320-iplimited.docx, UserGuide-1320-iplimited.pdf, ZOOKEEPER-1320-iplimited.patch, zookeeper-3.3.3.jar_iplimited
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1320) Add the feathre to zookeeper
allow client limited.
Posted by "Leader Ni (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164164#comment-13164164 ]
Leader Ni commented on ZOOKEEPER-1320:
--------------------------------------
Thanks to Ted Dunning and Patrick Hunt
> Add the feathre to zookeeper allow client limited.
> --------------------------------------------------
>
> Key: ZOOKEEPER-1320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1320
> Project: ZooKeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.3.3
> Environment: Linux version 2.6.18-164.el5 (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)), jdk-1.6.0_17
> Reporter: Leader Ni
> Assignee: Leader Ni
> Labels: client,server,limited,ipfilter
> Fix For: 3.3.5
>
> Attachments: UserGuide-1320-iplimited.docx, UserGuide-1320-iplimited.pdf, ZOOKEEPER-1320-iplimited.patch, zookeeper-3.3.3.jar_iplimited
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the feature to zookeeper so that administrator can set the list of ips that limit which nodes can connect to the zk servers and which connected clients can operate on data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira