You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/02/25 05:07:06 UTC

[GitHub] akashrn5 commented on a change in pull request #3133: [CARBONDATA-3301]Fix inserting null values to Array columns in carbon file format data load

akashrn5 commented on a change in pull request #3133: [CARBONDATA-3301]Fix inserting null values to Array<date>  columns in carbon file format data load
URL: https://github.com/apache/carbondata/pull/3133#discussion_r259678078
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java
 ##########
 @@ -344,7 +344,7 @@ public int getSurrogateIndex() {
             byte[] value = null;
             if (isDirectDictionary) {
               int surrogateKey;
-              if (!(input instanceof Long)) {
+              if (!(input instanceof Long) && !(input instanceof Integer)) {
 
 Review comment:
   no, it is problem with date only

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services