You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by jj...@apache.org on 2015/07/08 05:36:01 UTC
kafka git commit: KAFKA-2298;
Client Selector can drop connections on InvalidReceiveException
without notifying NetworkClient; reviewed by Jason Gustafson and Joel Koshy
Repository: kafka
Updated Branches:
refs/heads/trunk f13dd8024 -> 23d72bccb
KAFKA-2298; Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient; reviewed by Jason Gustafson and Joel Koshy
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/23d72bcc
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/23d72bcc
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/23d72bcc
Branch: refs/heads/trunk
Commit: 23d72bccbeeeb0774b86c47e05cdcd1575a5d38a
Parents: f13dd80
Author: Dong Lin <li...@gmail.com>
Authored: Tue Jul 7 18:09:00 2015 -0700
Committer: Joel Koshy <jj...@gmail.com>
Committed: Tue Jul 7 18:09:00 2015 -0700
----------------------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/network/Selector.java | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/23d72bcc/clients/src/main/java/org/apache/kafka/common/network/Selector.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/network/Selector.java b/clients/src/main/java/org/apache/kafka/common/network/Selector.java
index 4aee214..aaf60c9 100644
--- a/clients/src/main/java/org/apache/kafka/common/network/Selector.java
+++ b/clients/src/main/java/org/apache/kafka/common/network/Selector.java
@@ -279,6 +279,7 @@ public class Selector implements Selectable {
} catch (InvalidReceiveException e) {
log.error("Invalid data received from " + transmissions.id + " closing connection", e);
close(transmissions.id);
+ this.disconnected.add(transmissions.id);
throw e;
}
if (transmissions.receive.complete()) {