You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/15 20:01:56 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #6438: Python: Reduce the use of mock objects
Fokko opened a new pull request, #6438:
URL: https://github.com/apache/iceberg/pull/6438
We use mocks extensively in our Python code, this was before we had certain functionality available, such as a working FileIO.
Instead of using the mocks, we can also use the actual code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #6438: Python: Reduce the use of mock objects
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #6438:
URL: https://github.com/apache/iceberg/pull/6438#issuecomment-1356869306
@rdblue rebased! 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #6438: Python: Reduce the use of mock objects
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6438:
URL: https://github.com/apache/iceberg/pull/6438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #6438: Python: Reduce the use of mock objects
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #6438:
URL: https://github.com/apache/iceberg/pull/6438#issuecomment-1355572986
Looks good to me! I'm not merging in case you want to move/rename `AvroStruct` since it is really a generic class and not specific to Avro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6438: Python: Reduce the use of mock objects
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6438:
URL: https://github.com/apache/iceberg/pull/6438#discussion_r1051136493
##########
python/pyiceberg/avro/reader.py:
##########
@@ -104,16 +104,22 @@ def _skip_map_array(decoder: BinaryDecoder, skip_entry: Callable[[], None]) -> N
block_count = decoder.read_int()
-@dataclass(frozen=True)
class AvroStruct(StructProtocol):
- _data: List[Union[Any, StructProtocol]] = dataclassfield()
+ _data: List[Union[Any, StructProtocol]]
Review Comment:
Is anything here specific to Avro? Or should this be a generic struct in a different place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #6438: Python: Reduce the use of mock objects
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #6438:
URL: https://github.com/apache/iceberg/pull/6438#issuecomment-1356866813
Looks like this needs to be rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org