You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/07/31 15:18:30 UTC
[GitHub] [incubator-heron] huijunwu edited a comment on pull request #3588: Deep clean heron-explorer
huijunwu edited a comment on pull request #3588:
URL: https://github.com/apache/incubator-heron/pull/3588#issuecomment-667168233
tested on macos, several issues:
1. need to toggle verbose, see below
```
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer logical-plan local hello-world-topology
[2020-07-31 07:32:21 -0700] [DEBUG]: fetching url http://127.0.0.1:8888/topologies/logicalplan?cluster=local&environ=default&topology=hello-world-topology&role=huijunw
[2020-07-31 07:32:21 -0700] [DEBUG]: TIME: url fetch took 0.39 ms server time http://127.0.0.1:8888/topologies/logicalplan?cluster=local&environ=default&topology=hello-world-topology&role=huijunw
[2020-07-31 07:32:21 -0700] [DEBUG]: TIME: url fetch took 29.01 ms round trip http://127.0.0.1:8888/topologies/logicalplan?cluster=local&environ=default&topology=hello-world-topology&role=huijunw
[2020-07-31 07:32:21 -0700] [DEBUG]: fetching url http://127.0.0.1:8888/topologies/info?cluster=local&environ=default&topology=hello-world-topology&role=huijunw
[2020-07-31 07:32:21 -0700] [DEBUG]: TIME: url fetch took 0.11 ms server time http://127.0.0.1:8888/topologies/info?cluster=local&environ=default&topology=hello-world-topology&role=huijunw
[2020-07-31 07:32:21 -0700] [DEBUG]: TIME: url fetch took 4.45 ms round trip http://127.0.0.1:8888/topologies/info?cluster=local&environ=default&topology=hello-world-topology&role=huijunw
type name parallelism input output
------ -------- ------------- ------- --------
spout word 2 - exclaim1
bolt exclaim1 4 word -
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer --verbose logical-plan local hello-world-topology
type name parallelism input output
------ -------- ------------- ------- --------
spout word 2 - exclaim1
bolt exclaim1 4 word -
```
2. some options order in the help-info are wrong?
```
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer topologies --help
Usage: heron-explorer topologies [OPTIONS] CLUSTER[/ROLE[/ENV]]
Options:
--tracker-url TEXT
--help Show this message and exit.
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer topologies local --tracker-url http://127.0.0.1:8888
[2020-07-31 07:43:20 -0700] [DEBUG]: fetching url http://127.0.0.1:8888/topologies?cluster=local
[2020-07-31 07:43:20 -0700] [DEBUG]: TIME: url fetch took 0.10 ms server time http://127.0.0.1:8888/topologies?cluster=local
[2020-07-31 07:43:20 -0700] [DEBUG]: TIME: url fetch took 22.43 ms round trip http://127.0.0.1:8888/topologies?cluster=local
Topologies in local:
role env topology
------- ------- --------------------
huijunw default hello-world-topology
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer --tracker-url http://127.0.0.1:8888 topologies local
Usage: heron-explorer [OPTIONS] COMMAND [ARGS]...
Try 'heron-explorer --help' for help.
Error: no such option: --tracker-url
```
Should be `Usage: heron-explorer topologies CLUSTER[/ROLE[/ENV]] [OPTIONS]`rather than `Usage: heron-explorer topologies [OPTIONS] CLUSTER[/ROLE[/ENV]]`
`--tracker-url TEXT`, `TEXT` could be more descriptive
These issues exist as well for other sub-commands
3. looks like no difference of --component-type bolts/spouts/all
```
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer --verbose logical-plan local hello-world-topology --component-type bolts
type name parallelism input output
------ -------- ------------- ------- --------
spout word 2 - exclaim1
bolt exclaim1 4 word -
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer --verbose logical-plan local hello-world-topology --component-type spouts
type name parallelism input output
------ -------- ------------- ------- --------
spout word 2 - exclaim1
bolt exclaim1 4 word -
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer --verbose logical-plan local hello-world-topology --component-type all
type name parallelism input output
------ -------- ------------- ------- --------
spout word 2 - exclaim1
bolt exclaim1 4 word -
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer --verbose logical-plan local hello-world-topology --component-type all --help
Usage: heron-explorer logical-plan [OPTIONS] CLUSTER[/ROLE[/ENV]] TOPOLOGY
Options:
--config-path TEXT
--tracker-url TEXT
--component-type [all|spouts|bolts]
--help Show this message and exit.
```
'consolidating the explorer functionality into the heron CLI'. - this question looks equivalent to 'shall we put all cli into one?' Originally `heron-explorer` was built equivalent to heron-ui, as an easy tool displaying topology stats, when some user has only access to terminals. It is optional, while `heron` is mandatory. Would like to see strong motivation to put `heron-explorer` into `heron`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org