You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "John Casey (JIRA)" <ji...@codehaus.org> on 2009/03/10 18:11:12 UTC
[jira] Created: (MNG-4081) Subtle case: Avoid resolving artifacts
from outside the reactor for plugins and extensions whose projects are
inside the reactor
Subtle case: Avoid resolving artifacts from outside the reactor for plugins and extensions whose projects are inside the reactor
--------------------------------------------------------------------------------------------------------------------------------
Key: MNG-4081
URL: http://jira.codehaus.org/browse/MNG-4081
Project: Maven 2
Issue Type: Improvement
Reporter: John Casey
DefaultLifecycleExecutor.constructLifecycleMappings() can trigger the resolution of all the plugins declared in the project's build section. When this happens, even if those plugins are in the current reactor, *that version will not be used*. Instead, since those plugin artifacts haven't been built yet, the plugin will be resolved externally and bound into the plugin collector for later use. This means that even if the plugin itself isn't used until after it's build in the reactor, that version won't be used.
I'm still investigating exactly how build extensions will interact with the reactor, but I suspect they cannot be available from the current reactor either, since build extensions are loaded up front and for the entire reactor at once. I'll post an update once I've explored that section of the code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-4081) Subtle case: Avoid resolving artifacts
from outside the reactor for plugins and extensions whose projects are
inside the reactor
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MNG-4081.
----------------------------------
Resolution: Duplicate
Fix Version/s: (was: 3.0-beta-1)
Assignee: Benjamin Bentmann
For plugins, we can employ the reactor output (MNG-2135) and for extensions, we need an update to the model as outlined in another issue (MNG-1911).
> Subtle case: Avoid resolving artifacts from outside the reactor for plugins and extensions whose projects are inside the reactor
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-4081
> URL: http://jira.codehaus.org/browse/MNG-4081
> Project: Maven 2 & 3
> Issue Type: Improvement
> Affects Versions: 2.1.0-M1
> Reporter: John Casey
> Assignee: Benjamin Bentmann
>
> DefaultLifecycleExecutor.constructLifecycleMappings() can trigger the resolution of all the plugins declared in the project's build section. When this happens, even if those plugins are in the current reactor, *that version will not be used*. Instead, since those plugin artifacts haven't been built yet, the plugin will be resolved externally and bound into the plugin collector for later use. This means that even if the plugin itself isn't used until after it's build in the reactor, that version won't be used.
> I'm still investigating exactly how build extensions will interact with the reactor, but I suspect they cannot be available from the current reactor either, since build extensions are loaded up front and for the entire reactor at once. I'll post an update once I've explored that section of the code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-4081) Subtle case: Avoid resolving artifacts
from outside the reactor for plugins and extensions whose projects are
inside the reactor
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MNG-4081:
----------------------------
Affects Version/s: 2.1.0-M1
Fix Version/s: 2.x
> Subtle case: Avoid resolving artifacts from outside the reactor for plugins and extensions whose projects are inside the reactor
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-4081
> URL: http://jira.codehaus.org/browse/MNG-4081
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.1.0-M1
> Reporter: John Casey
> Fix For: 2.x
>
>
> DefaultLifecycleExecutor.constructLifecycleMappings() can trigger the resolution of all the plugins declared in the project's build section. When this happens, even if those plugins are in the current reactor, *that version will not be used*. Instead, since those plugin artifacts haven't been built yet, the plugin will be resolved externally and bound into the plugin collector for later use. This means that even if the plugin itself isn't used until after it's build in the reactor, that version won't be used.
> I'm still investigating exactly how build extensions will interact with the reactor, but I suspect they cannot be available from the current reactor either, since build extensions are loaded up front and for the entire reactor at once. I'll post an update once I've explored that section of the code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-4081) Subtle case: Avoid resolving artifacts
from outside the reactor for plugins and extensions whose projects are
inside the reactor
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-4081:
------------------------------
Fix Version/s: (was: 2.x)
3.0-alpha-7
for review under 3.0-alpha. Would be good to have a test case.
> Subtle case: Avoid resolving artifacts from outside the reactor for plugins and extensions whose projects are inside the reactor
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-4081
> URL: http://jira.codehaus.org/browse/MNG-4081
> Project: Maven 2 & 3
> Issue Type: Improvement
> Affects Versions: 2.1.0-M1
> Reporter: John Casey
> Fix For: 3.0-alpha-7
>
>
> DefaultLifecycleExecutor.constructLifecycleMappings() can trigger the resolution of all the plugins declared in the project's build section. When this happens, even if those plugins are in the current reactor, *that version will not be used*. Instead, since those plugin artifacts haven't been built yet, the plugin will be resolved externally and bound into the plugin collector for later use. This means that even if the plugin itself isn't used until after it's build in the reactor, that version won't be used.
> I'm still investigating exactly how build extensions will interact with the reactor, but I suspect they cannot be available from the current reactor either, since build extensions are loaded up front and for the entire reactor at once. I'll post an update once I've explored that section of the code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-4081) Subtle case: Avoid resolving artifacts
from outside the reactor for plugins and extensions whose projects are
inside the reactor
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=168797#action_168797 ]
John Casey commented on MNG-4081:
---------------------------------
Looking at DefaultExtensionManager.addExtension(..), extensions aren't even looked for in the current reactor. I suppose this makes sense, given how early extensions are added to the build runtime.
> Subtle case: Avoid resolving artifacts from outside the reactor for plugins and extensions whose projects are inside the reactor
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-4081
> URL: http://jira.codehaus.org/browse/MNG-4081
> Project: Maven 2
> Issue Type: Improvement
> Reporter: John Casey
>
> DefaultLifecycleExecutor.constructLifecycleMappings() can trigger the resolution of all the plugins declared in the project's build section. When this happens, even if those plugins are in the current reactor, *that version will not be used*. Instead, since those plugin artifacts haven't been built yet, the plugin will be resolved externally and bound into the plugin collector for later use. This means that even if the plugin itself isn't used until after it's build in the reactor, that version won't be used.
> I'm still investigating exactly how build extensions will interact with the reactor, but I suspect they cannot be available from the current reactor either, since build extensions are loaded up front and for the entire reactor at once. I'll post an update once I've explored that section of the code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira