You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "David Bertoni (JIRA)" <xa...@xml.apache.org> on 2007/06/06 04:09:25 UTC
[jira] Created: (XALANC-648) XalanUTF8Writer::write(const
XalanDOMChar*, XalanDOMString::size_type) does not handle surrogates
properly
XalanUTF8Writer::write(const XalanDOMChar*, XalanDOMString::size_type) does not handle surrogates properly
----------------------------------------------------------------------------------------------------------
Key: XALANC-648
URL: https://issues.apache.org/jira/browse/XALANC-648
Project: XalanC
Issue Type: Bug
Reporter: David Bertoni
Assignee: David Bertoni
This function need to decode surrogate pairs into the corresponding Unicode code point, just like its other write() overloads do.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANC-648) XalanUTF8Writer::write(const
XalanDOMChar*, XalanDOMString::size_type) does not handle surrogates
properly
Posted by "Dmitry Hayes (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANC-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513584 ]
Dmitry Hayes commented on XALANC-648:
-------------------------------------
I have two comments : first , I tried to rebuild XalanC first time for pretty long time and it seems that we have some build errors :
d:\LatestXalanC\src\xalanc\PlatformSupport\XalanLocator.hpp(94): error C2555: 'xalanc_1_10::XalanLocator::getColumnNumber': overriding virtual function return type differs and is not covariant from 'xercesc_2_7::Locator::getColumnNumber'
Xercec Locator::getColumnNumber() const ; returns XMLSSize_t , but XalanLocator::getColumnNumber() const return "unsigned long", and the compiler doesn't like it. Is it something new , I probably missed some latest additions.
2. Looking into the attached patch , I see some if(..) ... else's rearanged , but I can't find a scenario exposing the potential defect . Can you provide one ?
Thanks!
> XalanUTF8Writer::write(const XalanDOMChar*, XalanDOMString::size_type) does not handle surrogates properly
> ----------------------------------------------------------------------------------------------------------
>
> Key: XALANC-648
> URL: https://issues.apache.org/jira/browse/XALANC-648
> Project: XalanC
> Issue Type: Bug
> Affects Versions: CurrentCVS
> Reporter: David Bertoni
> Assignee: David Bertoni
> Attachments: patch.diff
>
>
> This function needs to decode surrogate pairs into the corresponding Unicode code point, just like the other write() overloads.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANC-648) XalanUTF8Writer::write(const
XalanDOMChar*, XalanDOMString::size_type) does not handle surrogates
properly
Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANC-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513631 ]
David Bertoni commented on XALANC-648:
--------------------------------------
The errors you are seeing are fixed by the changes I recently checked in for compatibility with the latest changes to Xerces-C.
I actually added checks for surrogate pairs in the write() overload. I then made the if/else blocks in all three write functions consistent.
This came up as the result of a _different_ problem someone reported about a different processor. When I tested it in Xalan-C, I discovered this bug. I will try to find the files that can be used to reproduce the problem and attach them to the issue.
> XalanUTF8Writer::write(const XalanDOMChar*, XalanDOMString::size_type) does not handle surrogates properly
> ----------------------------------------------------------------------------------------------------------
>
> Key: XALANC-648
> URL: https://issues.apache.org/jira/browse/XALANC-648
> Project: XalanC
> Issue Type: Bug
> Affects Versions: CurrentCVS
> Reporter: David Bertoni
> Assignee: David Bertoni
> Attachments: patch.diff
>
>
> This function needs to decode surrogate pairs into the corresponding Unicode code point, just like the other write() overloads.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org