You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/12/03 08:52:03 UTC

Review Request 28638: Refactoring of entity helpers in falcon-regression

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28638/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-927
    https://issues.apache.org/jira/browse/FALCON-927


Repository: falcon-git


Description
-------

Refactoring of entity helpers in falcon-regression


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ClusterEntityHelperImpl.java 4e31f55 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ColoHelper.java 3a3ddce 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/DataEntityHelperImpl.java 79c3b9c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ProcessEntityHelperImpl.java e86caaf 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/ClusterEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/EntityHelperFactory.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/FeedEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/ProcessEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/EntityHelperFactory.java fe57927 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/FalconClientBuilder.java 393541c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 7eab15c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/Brother.java 5d2708a 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 8cc6121 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java fcef570 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java be28344 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java 0fc01ef 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedResumeTest.java bb629b8 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java 1586f76 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java 1546886 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java 33fea84 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessDeleteTest.java 3291d6d 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java 7b561e5 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java 334b51a 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java 8996923 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java 7d1213e 

Diff: https://reviews.apache.org/r/28638/diff/


Testing
-------

tested


Thanks,

Ruslan Ostafiychuk


Re: Review Request 28638: Refactoring of entity helpers in falcon-regression

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28638/
-----------------------------------------------------------

(Updated Dec. 3, 2014, 7:53 a.m.)


Review request for Falcon.


Bugs: FALCON-927
    https://issues.apache.org/jira/browse/FALCON-927


Repository: falcon-git


Description (updated)
-------

Refactoring of entity helpers in falcon-regression

org/apache/falcon/regression/core/(interfaces -> helpers)/FalconClientBuilder.java
org/apache/falcon/regression/core/(interfaces/IEntityManagerHelper.java -> helpers/entity/AbstractEntityHelper.java)
org/apache/falcon/regression/core/helpers/(ClusterEntityHelperImpl.java -> entity/ClusterEntityHelper.java)
org/apache/falcon/regression/core/helpers/(DataEntityHelperImpl.java -> entity/FeedEntityHelper.java)
org/apache/falcon/regression/core/(interfaces -> helpers/entity)/EntityHelperFactory.java
org/apache/falcon/regression/core/helpers/(ProcessEntityHelperImpl.java -> entity/ProcessEntityHelper.java)


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ClusterEntityHelperImpl.java 4e31f55 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ColoHelper.java 3a3ddce 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/DataEntityHelperImpl.java 79c3b9c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ProcessEntityHelperImpl.java e86caaf 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/ClusterEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/EntityHelperFactory.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/FeedEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/ProcessEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/EntityHelperFactory.java fe57927 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/FalconClientBuilder.java 393541c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 7eab15c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/Brother.java 5d2708a 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 8cc6121 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java fcef570 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java be28344 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java 0fc01ef 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedResumeTest.java bb629b8 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java 1586f76 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java 1546886 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java 33fea84 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessDeleteTest.java 3291d6d 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java 7b561e5 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java 334b51a 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java 8996923 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java 7d1213e 

Diff: https://reviews.apache.org/r/28638/diff/


Testing
-------

tested


Thanks,

Ruslan Ostafiychuk


Re: Review Request 28638: Refactoring of entity helpers in falcon-regression

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28638/
-----------------------------------------------------------

(Updated Dec. 3, 2014, 7:52 a.m.)


Review request for Falcon.


Bugs: FALCON-927
    https://issues.apache.org/jira/browse/FALCON-927


Repository: falcon-git


Description (updated)
-------

Refactoring of entity helpers in falcon-regression

org/apache/falcon/regression/core/(interfaces ? helpers)/FalconClientBuilder.java
org/apache/falcon/regression/core/(interfaces/IEntityManagerHelper.java ? helpers/entity/AbstractEntityHelper.java)
org/apache/falcon/regression/core/helpers/(ClusterEntityHelperImpl.java ? entity/ClusterEntityHelper.java)
org/apache/falcon/regression/core/helpers/(DataEntityHelperImpl.java ? entity/FeedEntityHelper.java)
org/apache/falcon/regression/core/(interfaces ? helpers/entity)/EntityHelperFactory.java
org/apache/falcon/regression/core/helpers/(ProcessEntityHelperImpl.java ? entity/ProcessEntityHelper.java)


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ClusterEntityHelperImpl.java 4e31f55 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ColoHelper.java 3a3ddce 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/DataEntityHelperImpl.java 79c3b9c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/FalconClientBuilder.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ProcessEntityHelperImpl.java e86caaf 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/ClusterEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/EntityHelperFactory.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/FeedEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/ProcessEntityHelper.java PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/EntityHelperFactory.java fe57927 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/FalconClientBuilder.java 393541c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 7eab15c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/Brother.java 5d2708a 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 8cc6121 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java fcef570 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java be28344 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java 0fc01ef 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedResumeTest.java bb629b8 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java 1586f76 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java 1546886 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java 33fea84 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessDeleteTest.java 3291d6d 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java 7b561e5 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java 334b51a 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java 8996923 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java 7d1213e 

Diff: https://reviews.apache.org/r/28638/diff/


Testing
-------

tested


Thanks,

Ruslan Ostafiychuk