You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "lzcGeek (via GitHub)" <gi...@apache.org> on 2026/10/02 13:23:06 UTC

Re: [PR] Fix Firebird OFFSET/FETCH rewrite by visiting limitClause [shardingsphere]

lzcGeek commented on PR #39955:
URL: https://github.com/apache/shardingsphere/pull/39955#issuecomment-5953324302

   Thanks for the detailed review. Both issues are fixed:
   
   - The trailing pagination clause is now visited after `FROM`/`WHERE`/`GROUP BY`/`HAVING`/`ORDER BY`, so parameter markers are consumed in SQL order (`WHERE ?` → `OFFSET ?` → `FETCH FIRST ?`).
   - Added two Parser IT cases with a preceding `WHERE` placeholder, covering `OFFSET/FETCH` and `FETCH` alone. All 242 cases pass locally with JDK 25.
   - Removed the ordinary explanatory comments and redundant child checks, and merged the split statements into single lines within the 200-character limit.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org