You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Han Hong Fang (JIRA)" <ji...@apache.org> on 2011/03/11 04:24:59 UTC
[jira] Created: (GERONIMO-5861) Update a bundle within an EBA
Update a bundle within an EBA
-----------------------------
Key: GERONIMO-5861
URL: https://issues.apache.org/jira/browse/GERONIMO-5861
Project: Geronimo
Issue Type: New Feature
Security Level: public (Regular issues)
Components: deployment
Reporter: Han Hong Fang
Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009034#comment-13009034 ]
Rex Wang commented on GERONIMO-5861:
------------------------------------
some codes clean up At revision: 1083684
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Rex Wang
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5861) Update a bundle within an EBA
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033371#comment-13033371 ]
David Jencks commented on GERONIMO-5861:
----------------------------------------
I'm worried we are setting up unrealistic expectations for how --clean behaves. I think we should encourage people to expect it to behave as it does in karaf, so that you get back to original server state before you installed any applications or bundles. I think we should say that the current behavior where gbean based info such as config.xml is stored outside config admin control is a bug we are working to fix.
On the other hand I would expect restarting the eba should reflect the new eba contents.
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Rex Wang
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009033#comment-13009033 ]
Rex Wang commented on GERONIMO-5861:
------------------------------------
commit to trunk At revision: 1083683
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Rex Wang
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Gawor resolved GERONIMO-5861.
-----------------------------------
Resolution: Fixed
Fix Version/s: 3.0
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Jarek Gawor
> Fix For: 3.0
>
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Gawor reassigned GERONIMO-5861:
-------------------------------------
Assignee: Jarek Gawor (was: Rex Wang)
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Jarek Gawor
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015581#comment-13015581 ]
Jarek Gawor commented on GERONIMO-5861:
---------------------------------------
A few comments:
1) Is there a reason why EBADeploymentManager.updateEBAContent() takes a File which is converted to an URI in ExtendedDeploymentManager and then converted back to File in ApplicationGBean? Maybe the API should be just passing an InputStream around.
2) The FileInputStream in ApplicationGBean is not closed
3) The bundle refresh should only really need to happen if bundle update is successful. Right not the code is looking up the PackageAdmin service before the update() call.
4) Will this code be committed to M2 branch?
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Rex Wang
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016300#comment-13016300 ]
Rex Wang commented on GERONIMO-5861:
------------------------------------
Thanks a lot for the review, Jarek.
commit #1,#2,#3 at revision: 1089352 in trunk.
for #4, I won't do this. If we want to release M2, I suggest re-branch it.
-Rex
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Rex Wang
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032626#comment-13032626 ]
Jarek Gawor commented on GERONIMO-5861:
---------------------------------------
Right now when a bundle is updated within EBA, the changes will be gone once the server is started with --clean option or the EBA is restarted. I think we need to make sure the changes are persistent.
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Rex Wang
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rex Wang reassigned GERONIMO-5861:
----------------------------------
Assignee: Rex Wang
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Rex Wang
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045466#comment-13045466 ]
Jarek Gawor commented on GERONIMO-5861:
---------------------------------------
In revision 1133030 I updated the logic in updateApplicationContent() function to first resolve the bundle that was updated. That prevents a potential deadlock with PackageAdmin.
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Jarek Gawor
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-5861) Update a bundle within an EBA
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036571#comment-13036571 ]
Jarek Gawor commented on GERONIMO-5861:
---------------------------------------
In revision 1125175 I committed changes that make a bundle update in an EBA persistent. That's done by rewriting the .eba file with the updated contents.
I also had to update the logic a bit that did the actual bundle update and package refresh since it actually was starting and stopping the bundle twice.
> Update a bundle within an EBA
> -----------------------------
>
> Key: GERONIMO-5861
> URL: https://issues.apache.org/jira/browse/GERONIMO-5861
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: deployment
> Reporter: Han Hong Fang
> Assignee: Jarek Gawor
>
> Some EBAs might be huge and contain many bundles. Right now whenever a bundle in a EBA is updated, the entire EBA is re-assembled and re-deployed to the server. That of course, can be expensive if the application is big. So it would be nice if only the updated bundle was re-deployed to the server.
> This JIRA is for probably required changes to the server's deployer code for deploying & managing bundles within or outside of EBAs. And GEP JIRA is here: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-718
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira