You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2017/05/02 23:11:02 UTC
Re: Review Request 58394: Setup new directory for python http client
lib in src/python.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/#review173674
-----------------------------------------------------------
src/python/.gitignore
Lines 1 (patched)
<https://reviews.apache.org/r/58394/#comment246700>
Why do you need .virtualenv in this folder? I wouldn't expect us to create a .virtualenv directory anywhere within this subolder (at least not yet). Once we move the cli code under this folder it might make sense. But not yet.
src/python/lib/mesos/__init__.py
Lines 1 (patched)
<https://reviews.apache.org/r/58394/#comment246699>
I would exclude this from this commit.
It is not used anywhere, therefore it should not be included until the commit where it is used.
- Kevin Klues
On April 12, 2017, 9:44 p.m., Eric Chung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58394/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 9:44 p.m.)
>
>
> Review request for mesos, Jason Lai, Joseph Wu, and Kevin Klues.
>
>
> Bugs: MESOS-7310
> https://issues.apache.org/jira/browse/MESOS-7310
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Setup new directory for python http client lib in src/python.
>
>
> Diffs
> -----
>
> src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443
> src/python/.gitignore PRE-CREATION
> src/python/lib/mesos/__init__.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58394/diff/1/
>
>
> Testing
> -------
>
> Under src/cli_new:
> 1\. ./bootstrap
> 2\. . ./activate
> 3\. python
> 4\. >>> import mesos
> 5\. >>> mesos.\_\_path\_\_
> 6\. verify that the path printed out is indeed at src/python/lib/mesos
>
>
> Thanks,
>
> Eric Chung
>
>
Re: Review Request 58394: Setup new directory for python http client
lib in src/python.
Posted by Eric Chung <ci...@gmail.com>.
> On May 2, 2017, 11:11 p.m., Kevin Klues wrote:
> > src/python/lib/mesos/__init__.py
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/58394/diff/1/?file=1691043#file1691043line1>
> >
> > I would exclude this from this commit.
> > It is not used anywhere, therefore it should not be included until the commit where it is used.
>
> Eric Chung wrote:
> this makes it clear that this dir is a python package, in addition to making git check the dir in. i would like to keep it unless there is a very strong reason not to.
>
> Kevin Klues wrote:
> I just meant to remove the line for the absolute_import. I understand the need for the file in general.
gotcha. i'll remove the import statement
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/#review173674
-----------------------------------------------------------
On May 11, 2017, 6:34 p.m., Eric Chung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58394/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 6:34 p.m.)
>
>
> Review request for mesos, Jason Lai, Joseph Wu, and Kevin Klues.
>
>
> Bugs: MESOS-7310
> https://issues.apache.org/jira/browse/MESOS-7310
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/58394
>
>
> Diffs
> -----
>
> src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443
> src/python/.gitignore PRE-CREATION
> src/python/lib/mesos/__init__.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58394/diff/2/
>
>
> Testing
> -------
>
> Under src/cli_new:
> 1\. ./bootstrap
> 2\. . ./activate
> 3\. python
> 4\. >>> import mesos
> 5\. >>> mesos.\_\_path\_\_
> 6\. verify that the path printed out is indeed at src/python/lib/mesos
>
>
> Thanks,
>
> Eric Chung
>
>
Re: Review Request 58394: Setup new directory for python http client
lib in src/python.
Posted by Eric Chung <ci...@gmail.com>.
> On May 2, 2017, 11:11 p.m., Kevin Klues wrote:
> > src/python/.gitignore
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/58394/diff/1/?file=1691042#file1691042line1>
> >
> > Why do you need .virtualenv in this folder? I wouldn't expect us to create a .virtualenv directory anywhere within this subolder (at least not yet). Once we move the cli code under this folder it might make sense. But not yet.
good point, i'll remove it
> On May 2, 2017, 11:11 p.m., Kevin Klues wrote:
> > src/python/lib/mesos/__init__.py
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/58394/diff/1/?file=1691043#file1691043line1>
> >
> > I would exclude this from this commit.
> > It is not used anywhere, therefore it should not be included until the commit where it is used.
this makes it clear that this dir is a python package, in addition to making git check the dir in. i would like to keep it unless there is a very strong reason not to.
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/#review173674
-----------------------------------------------------------
On April 12, 2017, 9:44 p.m., Eric Chung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58394/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 9:44 p.m.)
>
>
> Review request for mesos, Jason Lai, Joseph Wu, and Kevin Klues.
>
>
> Bugs: MESOS-7310
> https://issues.apache.org/jira/browse/MESOS-7310
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Setup new directory for python http client lib in src/python.
>
>
> Diffs
> -----
>
> src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443
> src/python/.gitignore PRE-CREATION
> src/python/lib/mesos/__init__.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58394/diff/1/
>
>
> Testing
> -------
>
> Under src/cli_new:
> 1\. ./bootstrap
> 2\. . ./activate
> 3\. python
> 4\. >>> import mesos
> 5\. >>> mesos.\_\_path\_\_
> 6\. verify that the path printed out is indeed at src/python/lib/mesos
>
>
> Thanks,
>
> Eric Chung
>
>
Re: Review Request 58394: Setup new directory for python http client
lib in src/python.
Posted by Kevin Klues <kl...@gmail.com>.
> On May 2, 2017, 11:11 p.m., Kevin Klues wrote:
> > src/python/lib/mesos/__init__.py
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/58394/diff/1/?file=1691043#file1691043line1>
> >
> > I would exclude this from this commit.
> > It is not used anywhere, therefore it should not be included until the commit where it is used.
>
> Eric Chung wrote:
> this makes it clear that this dir is a python package, in addition to making git check the dir in. i would like to keep it unless there is a very strong reason not to.
I just meant to remove the line for the absolute_import. I understand the need for the file in general.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/#review173674
-----------------------------------------------------------
On May 11, 2017, 6:34 p.m., Eric Chung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58394/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 6:34 p.m.)
>
>
> Review request for mesos, Jason Lai, Joseph Wu, and Kevin Klues.
>
>
> Bugs: MESOS-7310
> https://issues.apache.org/jira/browse/MESOS-7310
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/58394
>
>
> Diffs
> -----
>
> src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443
> src/python/.gitignore PRE-CREATION
> src/python/lib/mesos/__init__.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58394/diff/2/
>
>
> Testing
> -------
>
> Under src/cli_new:
> 1\. ./bootstrap
> 2\. . ./activate
> 3\. python
> 4\. >>> import mesos
> 5\. >>> mesos.\_\_path\_\_
> 6\. verify that the path printed out is indeed at src/python/lib/mesos
>
>
> Thanks,
>
> Eric Chung
>
>