You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/10/09 23:47:48 UTC
Review Request 26526: Stack version must start with 2. to be
considered Hadoop-2.x compatible
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26526/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-7229
https://issues.apache.org/jira/browse/AMBARI-7229
Repository: ambari
Description
-------
Looking at JavaScript logic is seems these properties are processed only for Hadoop 2.x compatible stacks and App.js checks if the stack version starts with 2 to consider it Hadoop 2.x compatible, which is not the case with 0.8 version of BIGTOP stack.
PROPOSAL: the fact that a given stack is Hadoop 2.x compatible should not be tied to the vendor stack version number, but rather explicitly defined as a property either in the stack definition or the service definition. Alternatively, looking at the actual version of the HDFS service included in the stack will be able to reveal if the stack is Hadoop 2.x compliant.
Diffs
-----
ambari-web/app/app.js e057814
ambari-web/app/mappers/stack_service_mapper.js 1732549
ambari-web/test/app_test.js a8f5151
Diff: https://reviews.apache.org/r/26526/diff/
Testing
-------
tested e2e
Thanks,
Jaimin Jetly
Re: Review Request 26526: Stack version must start with 2. to be
considered Hadoop-2.x compatible
Posted by Alexander Denissov <ad...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26526/#review56086
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Denissov
On Oct. 9, 2014, 9:47 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26526/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 9:47 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-7229
> https://issues.apache.org/jira/browse/AMBARI-7229
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looking at JavaScript logic is seems these properties are processed only for Hadoop 2.x compatible stacks and App.js checks if the stack version starts with 2 to consider it Hadoop 2.x compatible, which is not the case with 0.8 version of BIGTOP stack.
> PROPOSAL: the fact that a given stack is Hadoop 2.x compatible should not be tied to the vendor stack version number, but rather explicitly defined as a property either in the stack definition or the service definition. Alternatively, looking at the actual version of the HDFS service included in the stack will be able to reveal if the stack is Hadoop 2.x compliant.
>
>
> Diffs
> -----
>
> ambari-web/app/app.js e057814
> ambari-web/app/mappers/stack_service_mapper.js 1732549
> ambari-web/test/app_test.js a8f5151
>
> Diff: https://reviews.apache.org/r/26526/diff/
>
>
> Testing
> -------
>
> tested e2e
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 26526: Stack version must start with 2. to be
considered Hadoop-2.x compatible
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26526/#review56088
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Oct. 9, 2014, 9:47 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26526/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 9:47 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-7229
> https://issues.apache.org/jira/browse/AMBARI-7229
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looking at JavaScript logic is seems these properties are processed only for Hadoop 2.x compatible stacks and App.js checks if the stack version starts with 2 to consider it Hadoop 2.x compatible, which is not the case with 0.8 version of BIGTOP stack.
> PROPOSAL: the fact that a given stack is Hadoop 2.x compatible should not be tied to the vendor stack version number, but rather explicitly defined as a property either in the stack definition or the service definition. Alternatively, looking at the actual version of the HDFS service included in the stack will be able to reveal if the stack is Hadoop 2.x compliant.
>
>
> Diffs
> -----
>
> ambari-web/app/app.js e057814
> ambari-web/app/mappers/stack_service_mapper.js 1732549
> ambari-web/test/app_test.js a8f5151
>
> Diff: https://reviews.apache.org/r/26526/diff/
>
>
> Testing
> -------
>
> tested e2e
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 26526: Stack version must start with 2. to be
considered Hadoop-2.x compatible
Posted by Saman Alvi <sa...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26526/#review56141
-----------------------------------------------------------
Ship it!
Ship It!
- Saman Alvi
On Oct. 9, 2014, 9:47 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26526/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 9:47 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-7229
> https://issues.apache.org/jira/browse/AMBARI-7229
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looking at JavaScript logic is seems these properties are processed only for Hadoop 2.x compatible stacks and App.js checks if the stack version starts with 2 to consider it Hadoop 2.x compatible, which is not the case with 0.8 version of BIGTOP stack.
> PROPOSAL: the fact that a given stack is Hadoop 2.x compatible should not be tied to the vendor stack version number, but rather explicitly defined as a property either in the stack definition or the service definition. Alternatively, looking at the actual version of the HDFS service included in the stack will be able to reveal if the stack is Hadoop 2.x compliant.
>
>
> Diffs
> -----
>
> ambari-web/app/app.js e057814
> ambari-web/app/mappers/stack_service_mapper.js 1732549
> ambari-web/test/app_test.js a8f5151
>
> Diff: https://reviews.apache.org/r/26526/diff/
>
>
> Testing
> -------
>
> tested e2e
>
>
> Thanks,
>
> Jaimin Jetly
>
>