You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/23 02:00:00 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28895: [SPARK-32055][CORE][SQL] Unify getReader and getReaderForRange in ShuffleManager
dongjoon-hyun commented on a change in pull request #28895:
URL: https://github.com/apache/spark/pull/28895#discussion_r443918615
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -322,7 +322,7 @@ private[spark] abstract class MapOutputTracker(conf: SparkConf) extends Logging
// For testing
def getMapSizesByExecutorId(shuffleId: Int, reduceId: Int)
: Iterator[(BlockManagerId, Seq[(BlockId, Long, Int)])] = {
- getMapSizesByExecutorId(shuffleId, reduceId, reduceId + 1)
+ getMapSizesByExecutorId(shuffleId, mapStatus => (0, mapStatus.length), reduceId, reduceId + 1)
Review comment:
Since `mapStatus => (0, mapStatus.length)` seems to be used frequently, do you think we can define this function somewhere to prevent mistake?
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -322,7 +322,7 @@ private[spark] abstract class MapOutputTracker(conf: SparkConf) extends Logging
// For testing
def getMapSizesByExecutorId(shuffleId: Int, reduceId: Int)
: Iterator[(BlockManagerId, Seq[(BlockId, Long, Int)])] = {
- getMapSizesByExecutorId(shuffleId, reduceId, reduceId + 1)
+ getMapSizesByExecutorId(shuffleId, mapStatus => (0, mapStatus.length), reduceId, reduceId + 1)
Review comment:
Since `mapStatus => (0, mapStatus.length)` seems to be used frequently, do you think we can define this function somewhere to prevent mistakes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org