You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "bobbai00 (via GitHub)" <gi...@apache.org> on 2026/07/10 05:28:40 UTC
[PR] refactor(sync-execution): migrate agent result contract [texera]
bobbai00 opened a new pull request, #6314:
URL: https://github.com/apache/texera/pull/6314
### What changes were proposed in this PR?
This is PR 1 of the split from #6009. It migrates the sync-execution backend and agent-service internals to the new execution summary contract while keeping the current frontend response shape compatible.
Core changes:
- Replace the sync-execution result model with `WorkflowExecutionSummary`, `OperatorExecutionSummary`, and `OperatorResultSummary`.
- Represent sampled rows as `[rowIndex, Tuple]` pairs instead of embedding row metadata into JSON result records.
- Reuse the shared `WorkflowFatalError` shape for execution and compilation-style failures.
- Update agent-service execution formatting, result cache, server paths, and tests to consume the new model.
- Keep `GET /agents/:id/operator-results` legacy-compatible through a temporary adapter, so the existing frontend continues to work until the follow-up frontend PR lands.
Main review files:
- `amber/src/main/scala/org/apache/texera/web/resource/SyncExecutionResource.scala`
- `agent-service/src/types/execution.ts`
- `agent-service/src/server.ts`
### Any related issues, documentation, discussions?
Part of #5750.
Part of #5747.
Split from #6009.
A follow-up PR will migrate the frontend to consume the new summary shape directly and remove the temporary compatibility adapter.
### How was this PR tested?
- `cd agent-service && bun test src/server.spec.ts src/agent/tools/result-formatting.spec.ts src/agent/tools/tools-utility.spec.ts src/agent/tools/workflow-execution-tools.spec.ts src/agent/workflow-result-state.spec.ts`
- `cd agent-service && bun run format:check`
- `cd agent-service && bun run typecheck`
- `sbt scalafmtCheckAll`
Attempted but did not complete locally:
- `sbt "WorkflowExecutionService / testOnly org.apache.texera.web.resource.SyncExecutionResourceSpec"`
The command failed before reaching the spec because local JOOQ generation could not authenticate to Postgres, then existing generated Java deprecation warnings hit `-Werror` during `DAO / Compile`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(sync-execution): migrate agent result contract [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6314:
URL: https://github.com/apache/texera/pull/6314#issuecomment-5986676365
This pull request has been automatically closed due to 37 days of inactivity.
If you would like to continue this work, please re-open the PR or open a new
one referencing this. Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(sync-execution): migrate agent result contract [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6314: refactor(sync-execution): migrate agent result contract
URL: https://github.com/apache/texera/pull/6314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(sync-execution): migrate agent result contract [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6314:
URL: https://github.com/apache/texera/pull/6314#issuecomment-4932316040
<!-- texera-benchmarks-comment -->
## ✅ No material benchmark regressions detected
🟢 4 better · 🔴 0 worse · ⚪ 11 noise (<±5%) · 0 without baseline
> Compared against main `1b42558` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/29071444926)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🟢 | bs=10 sw=10 sl=64 | 429 | 0.262 | 22,615/31,606/31,606 us | 🟢 -8.8% / 🔴 +109.1% |
| 🟢 | bs=100 sw=10 sl=64 | 938 | 0.573 | 104,367/126,451/126,451 us | 🟢 -10.7% / 🔴 +18.1% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,113 | 0.68 | 897,113/941,193/941,193 us | ⚪ within ±5% / 🟢 -11.0% |
<details><summary>Baseline details</summary>
Latest main `1b42558` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 429 tuples/sec | 429 tuples/sec | 779.42 tuples/sec | 0.0% | -45.0% |
| bs=10 sw=10 sl=64 | MB/s | 0.262 MB/s | 0.262 MB/s | 0.476 MB/s | 0.0% | -44.9% |
| bs=10 sw=10 sl=64 | p50 | 22,615 us | 23,590 us | 12,550 us | -4.1% | +80.2% |
| bs=10 sw=10 sl=64 | p95 | 31,606 us | 34,647 us | 15,115 us | -8.8% | +109.1% |
| bs=10 sw=10 sl=64 | p99 | 31,606 us | 34,647 us | 18,652 us | -8.8% | +69.5% |
| bs=100 sw=10 sl=64 | throughput | 938 tuples/sec | 928 tuples/sec | 1,000 tuples/sec | +1.1% | -6.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.573 MB/s | 0.566 MB/s | 0.61 MB/s | +1.2% | -6.1% |
| bs=100 sw=10 sl=64 | p50 | 104,367 us | 102,539 us | 99,872 us | +1.8% | +4.5% |
| bs=100 sw=10 sl=64 | p95 | 126,451 us | 141,556 us | 107,073 us | -10.7% | +18.1% |
| bs=100 sw=10 sl=64 | p99 | 126,451 us | 141,556 us | 114,377 us | -10.7% | +10.6% |
| bs=1000 sw=10 sl=64 | throughput | 1,113 tuples/sec | 1,121 tuples/sec | 1,020 tuples/sec | -0.7% | +9.1% |
| bs=1000 sw=10 sl=64 | MB/s | 0.68 MB/s | 0.684 MB/s | 0.622 MB/s | -0.6% | +9.2% |
| bs=1000 sw=10 sl=64 | p50 | 897,113 us | 896,636 us | 987,499 us | +0.1% | -9.2% |
| bs=1000 sw=10 sl=64 | p95 | 941,193 us | 928,974 us | 1,028,784 us | +1.3% | -8.5% |
| bs=1000 sw=10 sl=64 | p99 | 941,193 us | 928,974 us | 1,057,136 us | +1.3% | -11.0% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,466.09,200,128000,429,0.262,22615.32,31605.98,31605.98
1,100,10,64,20,2131.41,2000,1280000,938,0.573,104367.11,126450.87,126450.87
2,1000,10,64,20,17964.34,20000,12800000,1113,0.680,897112.58,941193.19,941193.19
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(sync-execution): migrate agent result contract [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6314:
URL: https://github.com/apache/texera/pull/6314#issuecomment-5754282134
This pull request has been automatically marked as **stale** because it has
not had any activity for 30 days. It will be closed in **7 days** if no
further activity occurs.
If this PR is still relevant, please:
- Push new commits or rebase onto the latest `main`, or
- Comment with a status update, or
- Address any open review feedback.
To exempt this PR from auto-close, a maintainer can add the `pinned` label.
Thank you for your contribution to Apache Texera (incubating)!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(sync-execution): migrate agent result contract [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6314:
URL: https://github.com/apache/texera/pull/6314#issuecomment-4932288935
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Ma77Ball`, `@Yicong-Huang`
You can notify them by mentioning `@Ma77Ball`, `@Yicong-Huang` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(sync-execution): migrate agent result contract [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6314:
URL: https://github.com/apache/texera/pull/6314#issuecomment-4932291278
### :warning: JUnit XML file not found
The CLI was unable to find any JUnit XML files to upload.
For more help, visit our [troubleshooting guide](https://docs.codecov.com/docs/test-analytics#troubleshooting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org