You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2015/04/21 21:51:45 UTC

Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/
-----------------------------------------------------------

Review request for Ambari, Florian Barca and Jayush Luniya.


Bugs: AMBARI-10604
    https://issues.apache.org/jira/browse/AMBARI-10604


Repository: ambari


Description
-------

[WinTP2] StackAdvisor for HDPWIN needs to be revisited


Diffs
-----

  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 

Diff: https://reviews.apache.org/r/33404/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [5.579s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
[INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------


Thanks,

Artem Baranchuk

Re: Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On April 24, 2015, 8:31 a.m., Jayush Luniya wrote:
> > 1. Please validate StackAdvisor changes on multi node cluster.
> > 2. Make sure that the masters are recommended on different nodes in multi node. 
> > 3. We should check if there is a test plan that is used to validate stackadvisor for Linux that we can use.

4. Also please update the patch with any changes that were committed in this week to the Linux stack advisors.


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/#review81462
-----------------------------------------------------------


On April 21, 2015, 9:45 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33404/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 9:45 p.m.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10604
>     https://issues.apache.org/jira/browse/AMBARI-10604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] StackAdvisor for HDPWIN needs to be revisited
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 
> 
> Diff: https://reviews.apache.org/r/33404/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [5.579s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
> [INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>

Re: Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On April 24, 2015, 8:31 a.m., Jayush Luniya wrote:
> > 1. Please validate StackAdvisor changes on multi node cluster.
> > 2. Make sure that the masters are recommended on different nodes in multi node. 
> > 3. We should check if there is a test plan that is used to validate stackadvisor for Linux that we can use.
> 
> Jayush Luniya wrote:
>     4. Also please update the patch with any changes that were committed in this week to the Linux stack advisors.

Sorry one more thing. Can you also add Srimanth to the review?


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/#review81462
-----------------------------------------------------------


On April 21, 2015, 9:45 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33404/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 9:45 p.m.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10604
>     https://issues.apache.org/jira/browse/AMBARI-10604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] StackAdvisor for HDPWIN needs to be revisited
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 
> 
> Diff: https://reviews.apache.org/r/33404/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [5.579s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
> [INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>

Re: Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/#review81462
-----------------------------------------------------------


1. Please validate StackAdvisor changes on multi node cluster.
2. Make sure that the masters are recommended on different nodes in multi node. 
3. We should check if there is a test plan that is used to validate stackadvisor for Linux that we can use.

- Jayush Luniya


On April 21, 2015, 9:45 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33404/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 9:45 p.m.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10604
>     https://issues.apache.org/jira/browse/AMBARI-10604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] StackAdvisor for HDPWIN needs to be revisited
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 
> 
> Diff: https://reviews.apache.org/r/33404/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [5.579s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
> [INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>

Re: Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/#review81268
-----------------------------------------------------------

Ship it!


Ship It!

- Florian Barca


On April 21, 2015, 9:45 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33404/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 9:45 p.m.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10604
>     https://issues.apache.org/jira/browse/AMBARI-10604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] StackAdvisor for HDPWIN needs to be revisited
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 
> 
> Diff: https://reviews.apache.org/r/33404/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [5.579s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
> [INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>

Re: Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/#review81460
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py
<https://reviews.apache.org/r/33404/#comment131850>

    Do we need to add AMS recommendations?
    
          "AMBARI_METRICS": self.recommendAmsConfigurations


- Jayush Luniya


On April 21, 2015, 9:45 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33404/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 9:45 p.m.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10604
>     https://issues.apache.org/jira/browse/AMBARI-10604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] StackAdvisor for HDPWIN needs to be revisited
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 
> 
> Diff: https://reviews.apache.org/r/33404/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [5.579s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
> [INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>

Re: Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/
-----------------------------------------------------------

(Updated Апрель 26, 2015, 10:14 п.п.)


Review request for Ambari, Eugene Chekanskiy, Florian Barca, Jayush Luniya, and Srimanth Gunturi.


Changes
-------

Patch updated by the latest changes form linux stacks and AMS recommendations and validation.


Bugs: AMBARI-10604
    https://issues.apache.org/jira/browse/AMBARI-10604


Repository: ambari


Description
-------

[WinTP2] StackAdvisor for HDPWIN needs to be revisited


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 7892c02 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 

Diff: https://reviews.apache.org/r/33404/diff/


Testing (updated)
-------

It was recommended to install master components on the different nodes during multinod cluster deployment!

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [5.579s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
[INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------


Thanks,

Artem Baranchuk

Re: Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/
-----------------------------------------------------------

(Updated Апрель 21, 2015, 9:45 п.п.)


Review request for Ambari, Florian Barca and Jayush Luniya.


Bugs: AMBARI-10604
    https://issues.apache.org/jira/browse/AMBARI-10604


Repository: ambari


Description
-------

[WinTP2] StackAdvisor for HDPWIN needs to be revisited


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 

Diff: https://reviews.apache.org/r/33404/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [5.579s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
[INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------


Thanks,

Artem Baranchuk

Re: Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

Posted by Artem Baranchuk <ab...@hortonworks.com>.

> On Апрель 21, 2015, 8:35 п.п., Florian Barca wrote:
> > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py, line 89
> > <https://reviews.apache.org/r/33404/diff/1/?file=938434#file938434line89>
> >
> >     Ensure that putYarnProperties doesn't clobber the existing values. Moving putYarnProperty above the super() call will simplify the scenario.

If you look at putProperty method you can see that it won't currupt existing properties. We don't need to reorganize it.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/#review81057
-----------------------------------------------------------


On Апрель 21, 2015, 7:51 п.п., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33404/
> -----------------------------------------------------------
> 
> (Updated Апрель 21, 2015, 7:51 п.п.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10604
>     https://issues.apache.org/jira/browse/AMBARI-10604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] StackAdvisor for HDPWIN needs to be revisited
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 
> 
> Diff: https://reviews.apache.org/r/33404/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [5.579s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
> [INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>

Re: Review Request 33404: [WinTP2] StackAdvisor for HDPWIN needs to be revisited

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33404/#review81057
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py
<https://reviews.apache.org/r/33404/#comment131277>

    Duplicate? See 2 rows above.



ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py
<https://reviews.apache.org/r/33404/#comment131279>

    Same as above.



ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py
<https://reviews.apache.org/r/33404/#comment131280>

    Ensure that putYarnProperties doesn't clobber the existing values. Moving putYarnProperty above the super() call will simplify the scenario.



ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py
<https://reviews.apache.org/r/33404/#comment131281>

    Same as for putYarnProperty.



ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py
<https://reviews.apache.org/r/33404/#comment131282>

    Same as above.


- Florian Barca


On April 21, 2015, 7:51 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33404/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 7:51 p.m.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-10604
>     https://issues.apache.org/jira/browse/AMBARI-10604
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] StackAdvisor for HDPWIN needs to be revisited
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py ce0739d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 050d43c 
> 
> Diff: https://reviews.apache.org/r/33404/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [5.579s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.868s]
> [INFO] Ambari Server ..................................... SUCCESS [1:30.087s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>