[GitHub] [spark] cloud-fan commented on a change in pull request #27650: [SPARK-30902][SQL] Default table provider should be decided by catalog implementations

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27650: [SPARK-30902][SQL] Default table provider should be decided by catalog implementations
URL: https://github.com/apache/spark/pull/27650#discussion_r383088236
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
 ##########
 @@ -298,10 +298,9 @@ private[sql] object CatalogV2Util {
       options: Map[String, String],
       location: Option[String],
       comment: Option[String],
-      provider: String): Map[String, String] = {
-    properties ++
-      options ++
-      Map(TableCatalog.PROP_PROVIDER -> provider) ++
+      provider: Option[String]): Map[String, String] = {
 
 Review comment:
   Yes, and a catalog can decide its own default provider or keep it as none if it doesn't support provider (e.g. JDBC)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org