[GitHub] [airflow] potiuk commented on a diff in pull request #33022: Affix webserver access_denied warning to be configurable

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #33022:
URL: https://github.com/apache/airflow/pull/33022#discussion_r1281720327


##########
airflow/www/auth.py:
##########
@@ -28,6 +28,10 @@
 T = TypeVar("T", bound=Callable)
 
 
+def get_access_denied_message():
+    return conf.get("webserver", "access_denied_message")

Review Comment:
   Not really. The `get_mandatory` is needed only when we want to have a value but the value has no default (for example when we want to get a URL that has no default but we **really** need it to be configured). 
   
   The way it works when it is put in config.yml is that "default" is automatically used as fallback if there is no fallback (It's been working like that already for quite some time via defaul_config.cfg  - so my recent change has not changed it - jut made it works without the default_config.cfg 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org