You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/10 08:50:47 UTC

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #7007: [Refactor] Refact code of sequence column

HappenLee commented on a change in pull request #7007:
URL: https://github.com/apache/incubator-doris/pull/7007#discussion_r746364472



##########
File path: be/src/exec/olap_scanner.cpp
##########
@@ -245,8 +246,9 @@ Status OlapScanner::_init_return_columns() {
                 break;
             }
         }
-        if (has_replace_col) {
-            _return_columns.push_back(_tablet->tablet_schema().sequence_col_idx());
+        if (auto sequence_col_idx = _tablet->tablet_schema().sequence_col_idx();
+            has_replace_col && std::find(_return_columns.begin(), _return_columns.end(), sequence_col_idx) == _return_columns.end()) {
+            _return_columns.push_back(sequence_col_idx);

Review comment:
       it's a bug, i fixed it.
   if you 'set show_hidden_columns = true;', select * from unique_table with sequnece column. In Debug mode will core.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org