You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stephen Butler <sb...@elego.de> on 2008/10/18 10:37:35 UTC
[PATCH] Removing a useless arg (svn_wc_get_tree_conflict)
Hi folks,
Here's a little diff for fixing up a patch I submitted, that was committed
as part of r33620. I had added a boolean arg to a function for an
optimization that we don't need. Redundant searching for an adm_access
that already exists in the caller is not so bad. And the whole adm_access
stuff is apparently going to be a lot less relevant in wc-ng, so I shouldn't
clutter an API with adm-related args.
Regards,
Steve
[[[
Remove a useless extra arg to svn_wc_get_tree_conflict(), which I added
in r33620.
* subversion/include/svn_wc.h
(svn_wc_get_tree_conflict): Remove boolean arg adm_access_is_parent.
* subversion/libsvn_wc/tree_conflicts.c
(svn_wc_get_tree_conflict): Remove if-else logic involving
adm_access_is_parent.
* subversion/libsvn_wc/status.c
(assemble_status): Track change to svn_wc_get_tree_conflict.
* subversion/libsvn_client/info.c
(info_found_entry_callback,
info_error_handler): Track change to svn_wc_get_tree_conflict.
]]]
Suggested by: julianfoad
--
Stephen Butler | Software Developer
elego Software Solutions GmbH
Gustav-Meyer-Allee 25 | 13355 Berlin | Germany
fon: +49 30 2345 8696 | mobile: +49 163 25 45 015
fax: +49 30 2345 8695 | http://www.elegosoft.com
Geschäftsführer: Olaf Wagner | Sitz der Gesellschaft: Berlin
Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194
Re: [PATCH] Removing a useless arg (svn_wc_get_tree_conflict)
Posted by Stephen Butler <sb...@elego.de>.
Quoting Stephen Butler <sb...@elego.de>:
> Hi folks,
>
> Here's a little diff for fixing up a patch I submitted, that was committed
> as part of r33620.
Just committed it myself as r33726.
Cheers,
Steve
--
Stephen Butler | Software Developer
elego Software Solutions GmbH
Gustav-Meyer-Allee 25 | 13355 Berlin | Germany
fon: +49 30 2345 8696 | mobile: +49 163 25 45 015
fax: +49 30 2345 8695 | http://www.elegosoft.com
Geschäftsführer: Olaf Wagner | Sitz der Gesellschaft: Berlin
Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org