[GitHub] [nifi] joewitt commented on pull request #5664: NIFI-9562: add 'archive' conflict resolution strategy to PutFile

[GitBox <gi...@apache.org>]

joewitt commented on pull request #5664:
URL: https://github.com/apache/nifi/pull/5664#issuecomment-1016690635


   I am not supportive of this change as there is already a good and more flexible mechanism for users to setup their flows for this behavior.  And notable the version of this processor pre Apache had all this bundled into a single mechanism.  It was highly error prone and too limiting.  The current model allows the user substantial flexibility in how they choose to handle conflicts, renaming, archive locations.
   
   In the current simpler form the user has a PutFile that if upon conflict they choose to fail.  On fail they can route to a different PutFile whereby the filename is changed first and so on.  You might suggest that 'fail' is not sufficient since there could be other types of failure like not enough disk space, etc.. and you want to know precisely that it failed due to a naming conflict.  If so the simpler change is to add a conflict resolution of 'namingconflict' and route to such a relationship.  But that distinction also in practice didn't turn out to be helpful.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org