You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Hyukjin Kwon (Jira)" <ji...@apache.org> on 2021/02/26 09:27:00 UTC

[jira] [Created] (SPARK-34553) Rename GITHUB_API_TOKEN to GITHUB_OAUTH_KEY in translate-contributors

Hyukjin Kwon created SPARK-34553:
------------------------------------

             Summary: Rename GITHUB_API_TOKEN to GITHUB_OAUTH_KEY in translate-contributors
                 Key: SPARK-34553
                 URL: https://issues.apache.org/jira/browse/SPARK-34553
             Project: Spark
          Issue Type: Improvement
          Components: Project Infra
    Affects Versions: 3.2.0
            Reporter: Hyukjin Kwon


{code}
dev/create-release/translate-contributors.py:GITHUB_OAUTH_KEY = os.environ.get("GITHUB_OAUTH_KEY", os.environ.get("GITHUB_API_TOKEN", None))
dev/create-release/translate-contributors.py:if not GITHUB_OAUTH_KEY:
dev/create-release/translate-contributors.py:    sys.exit("GITHUB_OAUTH_KEY must be set")
dev/create-release/translate-contributors.py:github_client = Github(GITHUB_OAUTH_KEY)
dev/github_jira_sync.py:GITHUB_OAUTH_KEY = os.environ.get("GITHUB_OAUTH_KEY")
dev/github_jira_sync.py:        request.add_header('Authorization', 'token %s' % GITHUB_OAUTH_KEY)
dev/github_jira_sync.py:        request.add_header('Authorization', 'token %s' % GITHUB_OAUTH_KEY)
dev/merge_spark_pr.py:GITHUB_OAUTH_KEY = os.environ.get("GITHUB_OAUTH_KEY")
dev/merge_spark_pr.py:        if GITHUB_OAUTH_KEY:
dev/merge_spark_pr.py:            request.add_header('Authorization', 'token %s' % GITHUB_OAUTH_KEY)
dev/run-tests-jenkins.py:    github_oauth_key = os.environ["GITHUB_OAUTH_KEY"]
{code}

Spark uses {{GITHUB_OAUTH_KEY}} for GitHub token, but translate-contributors script alone uses {{GITHUB_API_TOKEN}}. We should better match to make it easier to run the script



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org