You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/11/27 15:07:41 UTC
Re: Review Request 25388: Fix problems found by checkstyle in
falcon-regression
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25388/
-----------------------------------------------------------
(Updated Nov. 27, 2014, 2:07 p.m.)
Review request for Falcon.
Bugs: FALCON-684
https://issues.apache.org/jira/browse/FALCON-684
Repository: falcon-git
Description
-------
There are some problems in falcon-regression that can be found by checkstyle.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/TestEntityUtil.java b3f4b3c
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 5535e00
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/LineageHelper.java 88ea42e
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/FalconClientBuilder.java 02b7529
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 10465b5
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Edge.java ee98e51
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/EdgesResult.java 21d897c
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphEntity.java d35ced6
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphResult.java d4be61d
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Vertex.java acd7be8
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/ExecResult.java c5172eb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 11758ff
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java ee0c072
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 6e99f4d
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/FileUtil.java 1a97e1d
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/GraphAssert.java 9d75591
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java ba9c419
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java dd9fe5c
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/LogUtil.java ae157ad
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java 7c6c73d
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java c6217c1
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 97c6c75
falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java cf95107
falcon-regression/merlin-core/src/main/java/org/apache/falcon/security/FalconAuthorizationToken.java fa2caf9
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java 91d8e67
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseUITestClass.java aab3415
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/EntitiesPage.java 4dbe070
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/EntityPage.java 3b2d5d1
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/Page.java d6b55d4
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/ProcessPage.java 9dd5be2
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java e3af96d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java 2fa7740
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java 143789f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 164caa5
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java 88c26d5
Diff: https://reviews.apache.org/r/25388/diff/
Testing
-------
LineageApiTest, LineageApiProcessInstanceTest, PrismFeedUpdateTest
Thanks,
Ruslan Ostafiychuk
Re: Review Request 25388: Fix problems found by checkstyle in
falcon-regression
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25388/#review63227
-----------------------------------------------------------
Ship it!
Ship It!
- Paul Isaychuk
On Nov. 27, 2014, 2:07 p.m., Ruslan Ostafiychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25388/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 2:07 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-684
> https://issues.apache.org/jira/browse/FALCON-684
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> There are some problems in falcon-regression that can be found by checkstyle.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/TestEntityUtil.java b3f4b3c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 5535e00
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/LineageHelper.java 88ea42e
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/FalconClientBuilder.java 02b7529
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 10465b5
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Edge.java ee98e51
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/EdgesResult.java 21d897c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphEntity.java d35ced6
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphResult.java d4be61d
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Vertex.java acd7be8
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/ExecResult.java c5172eb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 11758ff
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java ee0c072
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 6e99f4d
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/FileUtil.java 1a97e1d
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/GraphAssert.java 9d75591
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java ba9c419
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java dd9fe5c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/LogUtil.java ae157ad
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java 7c6c73d
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java c6217c1
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 97c6c75
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java cf95107
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/security/FalconAuthorizationToken.java fa2caf9
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java 91d8e67
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseUITestClass.java aab3415
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/EntitiesPage.java 4dbe070
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/EntityPage.java 3b2d5d1
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/Page.java d6b55d4
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/ProcessPage.java 9dd5be2
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java e3af96d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java 2fa7740
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java 143789f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 164caa5
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java 88c26d5
>
> Diff: https://reviews.apache.org/r/25388/diff/
>
>
> Testing
> -------
>
> LineageApiTest, LineageApiProcessInstanceTest, PrismFeedUpdateTest
>
>
> Thanks,
>
> Ruslan Ostafiychuk
>
>