You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/11 17:01:03 UTC
[GitHub] codecov-io edited a comment on issue #6601: Refactor
selenium-related methods under `utils/selenium.py`
codecov-io edited a comment on issue #6601: Refactor selenium-related methods under `utils/selenium.py`
URL: https://github.com/apache/incubator-superset/pull/6601#issuecomment-451830274
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6601?src=pr&el=h1) Report
> Merging [#6601](https://codecov.io/gh/apache/incubator-superset/pull/6601?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8051818693672e2d03e77d270d66b6b7b52cc505?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `90.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6601/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6601?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6601 +/- ##
==========================================
+ Coverage 56.24% 56.25% +0.01%
==========================================
Files 518 521 +3
Lines 23014 23021 +7
Branches 2749 2749
==========================================
+ Hits 12944 12951 +7
Misses 9660 9660
Partials 410 410
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6601?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `76.75% <100%> (+0.12%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `69.27% <100%> (+0.16%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.28% <100%> (+0.01%)` | :arrow_up: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `59.45% <100%> (+0.36%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.72% <50%> (+0.02%)` | :arrow_up: |
| [superset/utils/json.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvanNvbi5weQ==) | `82% <82%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.07% <83.33%> (+0.03%)` | :arrow_up: |
| [superset/utils/selenium.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2VsZW5pdW0ucHk=) | `87.5% <87.5%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `87.33% <90.9%> (-1.12%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `78.47% <96.15%> (-1.63%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/6601/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6601?src=pr&el=footer). Last update [8051818...d2d7365](https://codecov.io/gh/apache/incubator-superset/pull/6601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org