You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/11/29 07:59:40 UTC
[GitHub] [echarts] plainheart opened a new pull request #16131: chore: tweak issue and pull request template
plainheart opened a new pull request #16131:
URL: https://github.com/apache/echarts/pull/16131
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
### What does this PR do?
Fix some typos and tweak the wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#discussion_r758150763
##########
File path: .github/ISSUE_TEMPLATE/feature_request.yml
##########
@@ -10,17 +10,17 @@ body:
For usage questions, please use the following resources:
- - Read the [docs](http://echarts.apache.org/option.html)
+ - Read the [docs](https://echarts.apache.org/option.html)
- Find in [examples](https://echarts.apache.org/examples/)
- Look for / ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/echarts)
- For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe our [mailing list](https://echarts.apache.org/en/maillist.html) to get updated with the project.
+ For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe to our [mailing list](https://echarts.apache.org/maillist.html) to get updated with the project.
Also try to search for your issue - it may have already been answered or even fixed in the development branch. However, if you find that an old, closed issue still persists in the latest version, you should open a new issue using the form below instead of commenting on the old issue.
- type: textarea
attributes:
- label: What Problem Does This Feature Solve
+ label: What problem does this feature solve?
Review comment:
What I'd like to suggest is as follows,
- Use _**Title case**_ if it's a noun. For example,
- **Current Behavior**
- **Expected Behavior**
- **Steps To Reproduce**
- Use _**Sentence case**_ if it's a question. For example,
- _**Is there an existing issue for this?**_
- _**Anything else?**_
- _**What problem does this feature solve?**_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#discussion_r758141317
##########
File path: .github/ISSUE_TEMPLATE/feature_request.yml
##########
@@ -10,17 +10,17 @@ body:
For usage questions, please use the following resources:
- - Read the [docs](http://echarts.apache.org/option.html)
+ - Read the [docs](https://echarts.apache.org/option.html)
- Find in [examples](https://echarts.apache.org/examples/)
- Look for / ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/echarts)
- For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe our [mailing list](https://echarts.apache.org/en/maillist.html) to get updated with the project.
+ For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe to our [mailing list](https://echarts.apache.org/maillist.html) to get updated with the project.
Also try to search for your issue - it may have already been answered or even fixed in the development branch. However, if you find that an old, closed issue still persists in the latest version, you should open a new issue using the form below instead of commenting on the old issue.
- type: textarea
attributes:
- label: What Problem Does This Feature Solve
+ label: What problem does this feature solve?
Review comment:
We can use some examples for refrence.
Template in GitHub Doc: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms#markdown-issue-template
TypeScript: https://github.com/microsoft/TypeScript/issues/new?assignees=&labels=&template=Bug_report.md&title=
What bothers me is the inconsistency. It looks very random in our template, or in the reference listed above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#issuecomment-981375355
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#discussion_r758126842
##########
File path: .github/ISSUE_TEMPLATE/feature_request.yml
##########
@@ -10,17 +10,17 @@ body:
For usage questions, please use the following resources:
- - Read the [docs](http://echarts.apache.org/option.html)
+ - Read the [docs](https://echarts.apache.org/option.html)
- Find in [examples](https://echarts.apache.org/examples/)
- Look for / ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/echarts)
- For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe our [mailing list](https://echarts.apache.org/en/maillist.html) to get updated with the project.
+ For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe to our [mailing list](https://echarts.apache.org/maillist.html) to get updated with the project.
Also try to search for your issue - it may have already been answered or even fixed in the development branch. However, if you find that an old, closed issue still persists in the latest version, you should open a new issue using the form below instead of commenting on the old issue.
- type: textarea
attributes:
- label: What Problem Does This Feature Solve
+ label: What problem does this feature solve?
Review comment:
It's better to be capitalized title like others here.
I found the `Link to minimal reproduction` and `Any additional comments` section is also not capitalized.
https://capitalizemytitle.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#discussion_r758170872
##########
File path: .github/ISSUE_TEMPLATE/feature_request.yml
##########
@@ -10,17 +10,17 @@ body:
For usage questions, please use the following resources:
- - Read the [docs](http://echarts.apache.org/option.html)
+ - Read the [docs](https://echarts.apache.org/option.html)
- Find in [examples](https://echarts.apache.org/examples/)
- Look for / ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/echarts)
- For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe our [mailing list](https://echarts.apache.org/en/maillist.html) to get updated with the project.
+ For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe to our [mailing list](https://echarts.apache.org/maillist.html) to get updated with the project.
Also try to search for your issue - it may have already been answered or even fixed in the development branch. However, if you find that an old, closed issue still persists in the latest version, you should open a new issue using the form below instead of commenting on the old issue.
- type: textarea
attributes:
- label: What Problem Does This Feature Solve
+ label: What problem does this feature solve?
Review comment:
Looks Good!
##########
File path: .github/ISSUE_TEMPLATE/feature_request.yml
##########
@@ -10,17 +10,17 @@ body:
For usage questions, please use the following resources:
- - Read the [docs](http://echarts.apache.org/option.html)
+ - Read the [docs](https://echarts.apache.org/option.html)
- Find in [examples](https://echarts.apache.org/examples/)
- Look for / ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/echarts)
- For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe our [mailing list](https://echarts.apache.org/en/maillist.html) to get updated with the project.
+ For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe to our [mailing list](https://echarts.apache.org/maillist.html) to get updated with the project.
Also try to search for your issue - it may have already been answered or even fixed in the development branch. However, if you find that an old, closed issue still persists in the latest version, you should open a new issue using the form below instead of commenting on the old issue.
- type: textarea
attributes:
- label: What Problem Does This Feature Solve
+ label: What problem does this feature solve?
Review comment:
Looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#issuecomment-981451551
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#discussion_r758150763
##########
File path: .github/ISSUE_TEMPLATE/feature_request.yml
##########
@@ -10,17 +10,17 @@ body:
For usage questions, please use the following resources:
- - Read the [docs](http://echarts.apache.org/option.html)
+ - Read the [docs](https://echarts.apache.org/option.html)
- Find in [examples](https://echarts.apache.org/examples/)
- Look for / ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/echarts)
- For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe our [mailing list](https://echarts.apache.org/en/maillist.html) to get updated with the project.
+ For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe to our [mailing list](https://echarts.apache.org/maillist.html) to get updated with the project.
Also try to search for your issue - it may have already been answered or even fixed in the development branch. However, if you find that an old, closed issue still persists in the latest version, you should open a new issue using the form below instead of commenting on the old issue.
- type: textarea
attributes:
- label: What Problem Does This Feature Solve
+ label: What problem does this feature solve?
Review comment:
What I'd like to suggest is as follows,
- Use _**Title case**_ if it's a noun. For example,
- **Current Behavior**
- **Expected Behavior**
- **Steps to Reproduce**
- Use _**Sentence case**_ if it's a question. For example,
- _**Is there an existing issue for this?**_
- _**Anything else?**_
- _**What problem does this feature solve?**_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#discussion_r758137546
##########
File path: .github/ISSUE_TEMPLATE/feature_request.yml
##########
@@ -10,17 +10,17 @@ body:
For usage questions, please use the following resources:
- - Read the [docs](http://echarts.apache.org/option.html)
+ - Read the [docs](https://echarts.apache.org/option.html)
- Find in [examples](https://echarts.apache.org/examples/)
- Look for / ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/echarts)
- For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe our [mailing list](https://echarts.apache.org/en/maillist.html) to get updated with the project.
+ For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe to our [mailing list](https://echarts.apache.org/maillist.html) to get updated with the project.
Also try to search for your issue - it may have already been answered or even fixed in the development branch. However, if you find that an old, closed issue still persists in the latest version, you should open a new issue using the form below instead of commenting on the old issue.
- type: textarea
attributes:
- label: What Problem Does This Feature Solve
+ label: What problem does this feature solve?
Review comment:
I personally think a form is just like asking the developer the questions, unlike the title of the paper or another formal one, taking it as a common talk is enough, so no need to capitalize all the first letters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart merged pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
plainheart merged pull request #16131:
URL: https://github.com/apache/echarts/pull/16131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#discussion_r758150763
##########
File path: .github/ISSUE_TEMPLATE/feature_request.yml
##########
@@ -10,17 +10,17 @@ body:
For usage questions, please use the following resources:
- - Read the [docs](http://echarts.apache.org/option.html)
+ - Read the [docs](https://echarts.apache.org/option.html)
- Find in [examples](https://echarts.apache.org/examples/)
- Look for / ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/echarts)
- For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe our [mailing list](https://echarts.apache.org/en/maillist.html) to get updated with the project.
+ For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe to our [mailing list](https://echarts.apache.org/maillist.html) to get updated with the project.
Also try to search for your issue - it may have already been answered or even fixed in the development branch. However, if you find that an old, closed issue still persists in the latest version, you should open a new issue using the form below instead of commenting on the old issue.
- type: textarea
attributes:
- label: What Problem Does This Feature Solve
+ label: What problem does this feature solve?
Review comment:
What I'd like to suggest is as follows,
- Use _**Title case**_ if it's a noun. For example,
- **Current Behavior**
- **Expected Behavior**
- **Steps To Reproduce**
- Use _**Sentence case**_ if it's a question. For example,
- **Is there an existing issue for this?**
- **Anything else?**
- **What problem does this feature solve?**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16131: chore: tweak issue and pull request template
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16131:
URL: https://github.com/apache/echarts/pull/16131#discussion_r758137546
##########
File path: .github/ISSUE_TEMPLATE/feature_request.yml
##########
@@ -10,17 +10,17 @@ body:
For usage questions, please use the following resources:
- - Read the [docs](http://echarts.apache.org/option.html)
+ - Read the [docs](https://echarts.apache.org/option.html)
- Find in [examples](https://echarts.apache.org/examples/)
- Look for / ask questions on [Stack Overflow](https://stackoverflow.com/questions/tagged/echarts)
- For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe our [mailing list](https://echarts.apache.org/en/maillist.html) to get updated with the project.
+ For non-technical support or general questions, you can email [dev@echarts.apache.org](mailto:dev@echarts.apache.org). And don't forget to subscribe to our [mailing list](https://echarts.apache.org/maillist.html) to get updated with the project.
Also try to search for your issue - it may have already been answered or even fixed in the development branch. However, if you find that an old, closed issue still persists in the latest version, you should open a new issue using the form below instead of commenting on the old issue.
- type: textarea
attributes:
- label: What Problem Does This Feature Solve
+ label: What problem does this feature solve?
Review comment:
I personally think a form is just like asking the developer the questions, unlike the title of the paper or another formal one, taking it as a common talk is enough, so no need to capitalize all the first letters.
\- That is, to use the _**Sentence case**_ option listed in the title capitalization tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org