You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Jingkei Ly (JIRA)" <ji...@apache.org> on 2008/02/19 17:34:43 UTC

[jira] Created: (HADOOP-2851) Bogus logging messages in Configration object constructors

Bogus logging messages in Configration object constructors
----------------------------------------------------------

                 Key: HADOOP-2851
                 URL: https://issues.apache.org/jira/browse/HADOOP-2851
             Project: Hadoop Core
          Issue Type: Bug
          Components: conf
    Affects Versions: 0.16.0
            Reporter: Jingkei Ly
            Priority: Trivial


The constructors for the Configuration object contains a superfluous logging message that logs an IOException whenever logging is enabled for the debug level. Basically both constructors have the statement:

if (LOG.isDebugEnabled()) {
      LOG.debug(StringUtils.stringifyException(new IOException("config()")));
    }

I can' t see any reason for it to be there and it just ends up leaving bogus IOExceptions in log files. It looks like its an old debug print statement which has accidentally been left in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2851) Bogus logging messages in Configration object constructors

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2851:
-------------------------------------------

    Attachment: 2851_20080925.patch

2851_20080925.patch: use trace level instead of debug level.

> Bogus logging messages in Configration object constructors
> ----------------------------------------------------------
>
>                 Key: HADOOP-2851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2851
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.16.0
>            Reporter: Jingkei Ly
>            Priority: Trivial
>         Attachments: 2851_20080925.patch
>
>
> The constructors for the Configuration object contains a superfluous logging message that logs an IOException whenever logging is enabled for the debug level. Basically both constructors have the statement:
> if (LOG.isDebugEnabled()) {
>       LOG.debug(StringUtils.stringifyException(new IOException("config()")));
>     }
> I can' t see any reason for it to be there and it just ends up leaving bogus IOExceptions in log files. It looks like its an old debug print statement which has accidentally been left in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2851) Bogus logging messages in Configration object constructors

Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589144#action_12589144 ] 

Steve Loughran commented on HADOOP-2851:
----------------------------------------

looks like someone wants a way to get a stack trace of wherever a configuration is created. Sometimes that could be useful. As it is only done if the debug log is enabled, its cost is otherwise minimal. 

Recommend leaving as is, file as INVALID or WONTFIX.


> Bogus logging messages in Configration object constructors
> ----------------------------------------------------------
>
>                 Key: HADOOP-2851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2851
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.16.0
>            Reporter: Jingkei Ly
>            Priority: Trivial
>
> The constructors for the Configuration object contains a superfluous logging message that logs an IOException whenever logging is enabled for the debug level. Basically both constructors have the statement:
> if (LOG.isDebugEnabled()) {
>       LOG.debug(StringUtils.stringifyException(new IOException("config()")));
>     }
> I can' t see any reason for it to be there and it just ends up leaving bogus IOExceptions in log files. It looks like its an old debug print statement which has accidentally been left in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2851) Bogus logging messages in Configration object constructors

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634714#action_12634714 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-2851:
------------------------------------------------

Since it is showing stack trace, how about change the log level from debug to trace?

> Bogus logging messages in Configration object constructors
> ----------------------------------------------------------
>
>                 Key: HADOOP-2851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2851
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.16.0
>            Reporter: Jingkei Ly
>            Priority: Trivial
>
> The constructors for the Configuration object contains a superfluous logging message that logs an IOException whenever logging is enabled for the debug level. Basically both constructors have the statement:
> if (LOG.isDebugEnabled()) {
>       LOG.debug(StringUtils.stringifyException(new IOException("config()")));
>     }
> I can' t see any reason for it to be there and it just ends up leaving bogus IOExceptions in log files. It looks like its an old debug print statement which has accidentally been left in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2851) Bogus logging messages in Configration object constructors

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2851:
-------------------------------------------

    Attachment: 2851_20081103.patch

Talked to Chris: these debug messages do not seem useful.  So they are better removed.

2851_20081103.patch: removed the debug messages and fixed all unchecked warning in Configuration.

> Bogus logging messages in Configration object constructors
> ----------------------------------------------------------
>
>                 Key: HADOOP-2851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2851
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.16.0
>            Reporter: Jingkei Ly
>            Priority: Trivial
>         Attachments: 2851_20080925.patch, 2851_20081103.patch
>
>
> The constructors for the Configuration object contains a superfluous logging message that logs an IOException whenever logging is enabled for the debug level. Basically both constructors have the statement:
> if (LOG.isDebugEnabled()) {
>       LOG.debug(StringUtils.stringifyException(new IOException("config()")));
>     }
> I can' t see any reason for it to be there and it just ends up leaving bogus IOExceptions in log files. It looks like its an old debug print statement which has accidentally been left in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.