You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/17 10:55:38 UTC

[GitHub] [flink] rkhachatryan commented on a change in pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

rkhachatryan commented on a change in pull request #18169:
URL: https://github.com/apache/flink/pull/18169#discussion_r785850767



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskExecutorStateChangelogStoragesManager.java
##########
@@ -124,10 +125,9 @@ public void releaseStateChangelogStorageForJob(@Nonnull JobID jobId) {
     }
 
     public void shutdown() {
-        if (closed) {
+        if (closed.getAndSet(true)) {
             return;
         }
-        closed = true;
 
         HashMap<JobID, Optional<StateChangelogStorage<?>>> toRelease =

Review comment:
       Thanks @dmvk, I've created FLINK-25678 to fix this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org