You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Kumar <ab...@gmail.com> on 2022/07/14 01:36:34 UTC
Review Request 74058: RANGER-3829: Incremental Sync Value to be read from usersync config
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74058/
-----------------------------------------------------------
Review request for ranger, Sailaja Polavarapu and Velmurugan Periasamy.
Bugs: RANGER-3829
https://issues.apache.org/jira/browse/RANGER-3829
Repository: ranger
Description
-------
Config parameter ranger.usersync.ldap.deltasync is hardcoded to true, the review allows the param to be read from config file.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/view/VXLdapSyncSourceInfo.java d349a9e25
ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/LdapSyncSourceInfo.java 227c89792
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 550775f65
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 531e35a95
Diff: https://reviews.apache.org/r/74058/diff/1/
Testing
-------
Thanks,
Abhishek Kumar
Re: Review Request 74058: RANGER-3829: Incremental Sync Value to be read from usersync config
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74058/#review224580
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On July 19, 2022, 1:51 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74058/
> -----------------------------------------------------------
>
> (Updated July 19, 2022, 1:51 a.m.)
>
>
> Review request for ranger, Sailaja Polavarapu and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3829
> https://issues.apache.org/jira/browse/RANGER-3829
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Config parameter ranger.usersync.ldap.deltasync is hardcoded to true, the review allows the param to be read from config file.
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 550775f65
>
>
> Diff: https://reviews.apache.org/r/74058/diff/2/
>
>
> Testing
> -------
>
> Tested on remote cluster.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 74058: RANGER-3829: Incremental Sync Value to be read from usersync config
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74058/#review224576
-----------------------------------------------------------
Ship it!
Ship It!
- Sailaja Polavarapu
On July 19, 2022, 1:51 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74058/
> -----------------------------------------------------------
>
> (Updated July 19, 2022, 1:51 a.m.)
>
>
> Review request for ranger, Sailaja Polavarapu and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3829
> https://issues.apache.org/jira/browse/RANGER-3829
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Config parameter ranger.usersync.ldap.deltasync is hardcoded to true, the review allows the param to be read from config file.
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 550775f65
>
>
> Diff: https://reviews.apache.org/r/74058/diff/2/
>
>
> Testing
> -------
>
> Tested on remote cluster.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 74058: RANGER-3829: Incremental Sync Value to be read from usersync config
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74058/
-----------------------------------------------------------
(Updated July 19, 2022, 1:51 a.m.)
Review request for ranger, Sailaja Polavarapu and Velmurugan Periasamy.
Bugs: RANGER-3829
https://issues.apache.org/jira/browse/RANGER-3829
Repository: ranger
Description
-------
Config parameter ranger.usersync.ldap.deltasync is hardcoded to true, the review allows the param to be read from config file.
Diffs (updated)
-----
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 550775f65
Diff: https://reviews.apache.org/r/74058/diff/2/
Changes: https://reviews.apache.org/r/74058/diff/1-2/
Testing (updated)
-------
Tested on remote cluster.
Thanks,
Abhishek Kumar