You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Michael Osipov <mi...@apache.org> on 2019/12/31 08:40:58 UTC
Next core beta
Folks,
is there anything open for the next core 5 beta? If not, Oleg would you
do the honors and start the release process?
thank you,
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Next core beta
Posted by Ryan Schmitt <rs...@apache.org>.
It looks like we already have logic from the Apache 4 integration that will
handle consecutive slashes:
https://github.com/aws/aws-sdk-java-v2/blob/2a303333f2b349209918a857a860266bb46102c2/http-clients/apache-client/src/main/java/software/amazon/awssdk/http/apache/internal/impl/ApacheHttpRequestFactory.java#L64-L75
To be honest, I don't have a very deep understanding of what all the fuss
was about last time around, and I still need to investigate and test this
when I get back in the office tomorrow.
On Wed, Jan 1, 2020 at 5:43 AM Oleg Kalnichevski <ol...@ok2consulting.com>
wrote:
> On Tue, 2019-12-31 at 14:02 -0800, Ryan Schmitt wrote:
> > I read through that, but I didn't see a specific explanation of what
> > would
> > need to be fixed and how.
> >
> > Either way, it's not really interesting. I need to be able to call S3
> > as-is, warts and all, or the client is unusable.
> >
> > On Tue, Dec 31, 2019 at 12:48 PM Michael Osipov <mi...@apache.org>
> > wrote:
> >
> > > Am 2019-12-31 um 20:01 schrieb Michael Osipov:
> > > > Am 2019-12-31 um 19:50 schrieb Ryan Schmitt:
> > > > > I don't have anything open for the next beta release. However,
> > > > > before
> > > > > we do
> > > > > a GA release, I need to investigate how URI normalization
> > > > > currently
> > >
> > > works
> > > > > in 5.x. The URI normalization changes in 4.5.x caused a lot of
> > > > > problems for
> > > > > the AWS SDK, so I want to make sure we don't get off on the
> > > > > wrong foot.
> > > >
>
> Hi Ryan
>
> The latest versions of both HttpClient 4.5 and HttpClient 5.0 only re-
> encode the path component only if contains multiple consecutive
> slashes, otherwise the original encoding is preserved as is. I presume
> this should be good enough for the greatest majority of users.
>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Next core beta
Posted by Oleg Kalnichevski <ol...@ok2consulting.com>.
On Tue, 2019-12-31 at 14:02 -0800, Ryan Schmitt wrote:
> I read through that, but I didn't see a specific explanation of what
> would
> need to be fixed and how.
>
> Either way, it's not really interesting. I need to be able to call S3
> as-is, warts and all, or the client is unusable.
>
> On Tue, Dec 31, 2019 at 12:48 PM Michael Osipov <mi...@apache.org>
> wrote:
>
> > Am 2019-12-31 um 20:01 schrieb Michael Osipov:
> > > Am 2019-12-31 um 19:50 schrieb Ryan Schmitt:
> > > > I don't have anything open for the next beta release. However,
> > > > before
> > > > we do
> > > > a GA release, I need to investigate how URI normalization
> > > > currently
> >
> > works
> > > > in 5.x. The URI normalization changes in 4.5.x caused a lot of
> > > > problems for
> > > > the AWS SDK, so I want to make sure we don't get off on the
> > > > wrong foot.
> > >
Hi Ryan
The latest versions of both HttpClient 4.5 and HttpClient 5.0 only re-
encode the path component only if contains multiple consecutive
slashes, otherwise the original encoding is preserved as is. I presume
this should be good enough for the greatest majority of users.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Next core beta
Posted by Ryan Schmitt <rs...@apache.org>.
I read through that, but I didn't see a specific explanation of what would
need to be fixed and how.
Either way, it's not really interesting. I need to be able to call S3
as-is, warts and all, or the client is unusable.
On Tue, Dec 31, 2019 at 12:48 PM Michael Osipov <mi...@apache.org> wrote:
> Am 2019-12-31 um 20:01 schrieb Michael Osipov:
> > Am 2019-12-31 um 19:50 schrieb Ryan Schmitt:
> >> I don't have anything open for the next beta release. However, before
> >> we do
> >> a GA release, I need to investigate how URI normalization currently
> works
> >> in 5.x. The URI normalization changes in 4.5.x caused a lot of
> >> problems for
> >> the AWS SDK, so I want to make sure we don't get off on the wrong foot.
> >
> > I have left a few comments on those PRs expressing that their services
> > URI handling is wrong -- yet they have chosen to fix the symptom only.
>
> here you go: https://github.com/aws/aws-sdk-java/pull/1966
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Next core beta
Posted by Michael Osipov <mi...@apache.org>.
Am 2019-12-31 um 20:01 schrieb Michael Osipov:
> Am 2019-12-31 um 19:50 schrieb Ryan Schmitt:
>> I don't have anything open for the next beta release. However, before
>> we do
>> a GA release, I need to investigate how URI normalization currently works
>> in 5.x. The URI normalization changes in 4.5.x caused a lot of
>> problems for
>> the AWS SDK, so I want to make sure we don't get off on the wrong foot.
>
> I have left a few comments on those PRs expressing that their services
> URI handling is wrong -- yet they have chosen to fix the symptom only.
here you go: https://github.com/aws/aws-sdk-java/pull/1966
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Next core beta
Posted by Michael Osipov <mi...@apache.org>.
I can't find it either. It was about restoring the previous behavior by
calling RequestConfig, as far as I remember.
I will keep looking and pass the link.
Am 2019-12-31 um 21:16 schrieb Ryan Schmitt:
> I cannot find these comments.
>
> On Tue, Dec 31, 2019 at 11:01 AM Michael Osipov <mi...@apache.org> wrote:
>
>> Am 2019-12-31 um 19:50 schrieb Ryan Schmitt:
>>> I don't have anything open for the next beta release. However, before we
>> do
>>> a GA release, I need to investigate how URI normalization currently works
>>> in 5.x. The URI normalization changes in 4.5.x caused a lot of problems
>> for
>>> the AWS SDK, so I want to make sure we don't get off on the wrong foot.
>>
>> I have left a few comments on those PRs expressing that their services
>> URI handling is wrong -- yet they have chosen to fix the symptom only.
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Next core beta
Posted by Ryan Schmitt <rs...@apache.org>.
I cannot find these comments.
On Tue, Dec 31, 2019 at 11:01 AM Michael Osipov <mi...@apache.org> wrote:
> Am 2019-12-31 um 19:50 schrieb Ryan Schmitt:
> > I don't have anything open for the next beta release. However, before we
> do
> > a GA release, I need to investigate how URI normalization currently works
> > in 5.x. The URI normalization changes in 4.5.x caused a lot of problems
> for
> > the AWS SDK, so I want to make sure we don't get off on the wrong foot.
>
> I have left a few comments on those PRs expressing that their services
> URI handling is wrong -- yet they have chosen to fix the symptom only.
>
Re: Next core beta
Posted by Michael Osipov <mi...@apache.org>.
Am 2019-12-31 um 19:50 schrieb Ryan Schmitt:
> I don't have anything open for the next beta release. However, before we do
> a GA release, I need to investigate how URI normalization currently works
> in 5.x. The URI normalization changes in 4.5.x caused a lot of problems for
> the AWS SDK, so I want to make sure we don't get off on the wrong foot.
I have left a few comments on those PRs expressing that their services
URI handling is wrong -- yet they have chosen to fix the symptom only.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Next core beta
Posted by Ryan Schmitt <rs...@apache.org>.
I don't have anything open for the next beta release. However, before we do
a GA release, I need to investigate how URI normalization currently works
in 5.x. The URI normalization changes in 4.5.x caused a lot of problems for
the AWS SDK, so I want to make sure we don't get off on the wrong foot.
On Tue, Dec 31, 2019 at 12:41 AM Michael Osipov <mi...@apache.org> wrote:
> Folks,
>
> is there anything open for the next core 5 beta? If not, Oleg would you
> do the honors and start the release process?
>
> thank you,
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Next core beta
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Tue, 2019-12-31 at 18:51 +0100, Michael Osipov wrote:
> Am 2019-12-31 um 17:55 schrieb Oleg Kalnichevski:
> > On Tue, 2019-12-31 at 11:10 -0500, Gary Gregory wrote:
> > > Micheal and all:
> > >
> > > - https://github.com/apache/httpcomponents-client/pull/194
> > > followed
> > > by
> > > - https://github.com/apache/httpcomponents-client/pull/195
> > >
> > > Gary
> > >
> >
> > That should not block HttpCore release, should it?
> >
> > Is there anything left blocking HttpCore? There will still be time
> > to
> > work on HttpClient in the meantime.
>
> I don't think so. I am still looking into StandardFilters. as far as
> I
> understand, this is the same as ChainElement in HttpClient?
Yes, it is, just server-side.
If yes, it
> indicates specific position in the chain rather than a specific
> filter,
> doesn't it?
>
It is serves exactly the same purpose as ChainElement in HttpClient.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Next core beta
Posted by Michael Osipov <mi...@apache.org>.
Am 2019-12-31 um 17:55 schrieb Oleg Kalnichevski:
> On Tue, 2019-12-31 at 11:10 -0500, Gary Gregory wrote:
>> Micheal and all:
>>
>> - https://github.com/apache/httpcomponents-client/pull/194 followed
>> by
>> - https://github.com/apache/httpcomponents-client/pull/195
>>
>> Gary
>>
>
> That should not block HttpCore release, should it?
>
> Is there anything left blocking HttpCore? There will still be time to
> work on HttpClient in the meantime.
I don't think so. I am still looking into StandardFilters. as far as I
understand, this is the same as ChainElement in HttpClient? If yes, it
indicates specific position in the chain rather than a specific filter,
doesn't it?
M
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Next core beta
Posted by Gary Gregory <ga...@gmail.com>.
On Tue, Dec 31, 2019 at 11:55 AM Oleg Kalnichevski <ol...@apache.org> wrote:
> On Tue, 2019-12-31 at 11:10 -0500, Gary Gregory wrote:
> > Micheal and all:
> >
> > - https://github.com/apache/httpcomponents-client/pull/194 followed
> > by
> > - https://github.com/apache/httpcomponents-client/pull/195
> >
> > Gary
> >
>
> That should not block HttpCore release, should it?
>
These PRs are simple and straightforward, there is no reason to omit these
from my POV.
IMO changes b/w the last Beta and GA should not contain binary
compatibility breaks, only little tweaks, giving the impression that the
API is fully baked, but, that's just a wish from me.
Gary
> Is there anything left blocking HttpCore? There will still be time to
> work on HttpClient in the meantime.
>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Next core beta
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Tue, 2019-12-31 at 11:10 -0500, Gary Gregory wrote:
> Micheal and all:
>
> - https://github.com/apache/httpcomponents-client/pull/194 followed
> by
> - https://github.com/apache/httpcomponents-client/pull/195
>
> Gary
>
That should not block HttpCore release, should it?
Is there anything left blocking HttpCore? There will still be time to
work on HttpClient in the meantime.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Next core beta
Posted by Gary Gregory <ga...@gmail.com>.
Micheal and all:
- https://github.com/apache/httpcomponents-client/pull/194 followed by
- https://github.com/apache/httpcomponents-client/pull/195
Gary
On Tue, Dec 31, 2019 at 9:20 AM Gary Gregory <ga...@gmail.com> wrote:
> Michael and all: https://github.com/apache/httpcomponents-core/pull/180
>
> Gary
>
> On Tue, Dec 31, 2019 at 3:41 AM Michael Osipov <mi...@apache.org>
> wrote:
>
>> Folks,
>>
>> is there anything open for the next core 5 beta? If not, Oleg would you
>> do the honors and start the release process?
>>
>> thank you,
>>
>> Michael
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>> For additional commands, e-mail: dev-help@hc.apache.org
>>
>>
Re: Next core beta
Posted by Gary Gregory <ga...@gmail.com>.
Michael and all: https://github.com/apache/httpcomponents-core/pull/180
Gary
On Tue, Dec 31, 2019 at 3:41 AM Michael Osipov <mi...@apache.org> wrote:
> Folks,
>
> is there anything open for the next core 5 beta? If not, Oleg would you
> do the honors and start the release process?
>
> thank you,
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Next core beta
Posted by Michael Osipov <mi...@apache.org>.
Am 2019-12-31 um 10:52 schrieb Oleg Kalnichevski:
> On Tue, 2019-12-31 at 09:40 +0100, Michael Osipov wrote:
>> Folks,
>>
>> is there anything open for the next core 5 beta? If not, Oleg would
>> you
>> do the honors and start the release process?
>>
>> thank you,
>>
>> Michael
>
> Will do tomorrow as soon as I get a nod from Ryan and Gary.
>
> You might want to rename `StandardFilters` to `StandardFilter` in core,
> though. It got overlooked I suppose.
Oh yes, thanks. I missed that one competely!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Next core beta
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Tue, 2019-12-31 at 09:40 +0100, Michael Osipov wrote:
> Folks,
>
> is there anything open for the next core 5 beta? If not, Oleg would
> you
> do the honors and start the release process?
>
> thank you,
>
> Michael
Will do tomorrow as soon as I get a nod from Ryan and Gary.
You might want to rename `StandardFilters` to `StandardFilter` in core,
though. It got overlooked I suppose.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org