You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/05/02 08:26:44 UTC
Review Request 58916: Fixed a minor bug in setting the agent's
`totalResources`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58916/
-----------------------------------------------------------
Review request for mesos and Jiang Yan Xu.
Repository: mesos
Description
-------
If the following branch is taken, `totalResources` would be set
to `resources.get()` which is not equal to `info.resources()`.
```cpp
if (HookManager::hooksAvailable()) {
info.mutable_resources()->CopyFrom(
HookManager::slaveResourcesDecorator(info));
}
```
Diffs
-----
src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a
Diff: https://reviews.apache.org/r/58916/diff/1/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 58916: Fixed a minor bug in setting the agent's
`totalResources`.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58916/#review173597
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On May 2, 2017, 1:26 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58916/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 1:26 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the following branch is taken, `totalResources` would be set
> to `resources.get()` which is not equal to `info.resources()`.
>
> ```cpp
> if (HookManager::hooksAvailable()) {
> info.mutable_resources()->CopyFrom(
> HookManager::slaveResourcesDecorator(info));
> }
> ```
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a
>
>
> Diff: https://reviews.apache.org/r/58916/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 58916: Fixed a minor bug in setting the agent's
`totalResources`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58916/#review173681
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58916]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 2, 2017, 8:26 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58916/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 8:26 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the following branch is taken, `totalResources` would be set
> to `resources.get()` which is not equal to `info.resources()`.
>
> ```cpp
> if (HookManager::hooksAvailable()) {
> info.mutable_resources()->CopyFrom(
> HookManager::slaveResourcesDecorator(info));
> }
> ```
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a
>
>
> Diff: https://reviews.apache.org/r/58916/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>