[jira] [Commented] (HBASE-22598) Deprecated the hbase.ipc.server.reservoir.initial.buffer.size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility

["Reid Chan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865462#comment-16865462 ] 

Reid Chan commented on HBASE-22598:
-----------------------------------

Yep, it's better to keep them take effect too, at least till 4.0.

{{LOG.WARN}} to raise attention.

(The deprecated methods or parameters should be kept for one more major version, IIRC

> Deprecated the hbase.ipc.server.reservoir.initial.buffer.size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-22598
>                 URL: https://issues.apache.org/jira/browse/HBASE-22598
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Major
>
> In https://github.com/apache/hbase/pull/301/files, we have a doc says: 
> bq. In HBase3.x, the configure hbase.ipc.server.reservoir.initial.buffer.size and hbase.ipc.server.reservoir.initial.max are deprecated now, instead please
> use the hbase.server.allocator.buffer.size and hbase.server.allocator.max.buffer.count.
> While in the current branch HBASE-21879,  the two config hbase.ipc.server.reservoir.initial.buffer.size and hbase.ipc.server.reservoir.initial.max  won't have any effect now,  should make those two deprecated instead of removing for better HBase2.x compatibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)