You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/29 02:00:43 UTC
[GitHub] [zookeeper] Shoothzj edited a comment on pull request #1574: ZOOKEEPER-4054: Make prometheus listen host can configure
Shoothzj edited a comment on pull request #1574:
URL: https://github.com/apache/zookeeper/pull/1574#issuecomment-809014582
> @Shoothzj I retry the CI, it became green. But when I run the UT(`testInvalidAddr`) in my local mac:
>
> ```
> org.junit.ComparisonFailure:
> Expected :java.net.SocketException: Unresolved address
> Actual :java.io.IOException: Failed to bind to 256.256.256.256:7000
> ```
>
> What's wrong with me? or the test is flaky?
I test it on my local mac too. `jdk8u251` and `jdk14.0.1`. I think may be the class **IPAddressUtil**'s method `textToNumericFormatV4` think `256.256.256.256` as an valid ip address.
Could you tell me your jdk version and which jdk you use?
If it's unstable, may be it's better to change a testcase to listen to invalid domain name like this , what do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org