You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/04 13:03:56 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10793: feat: SavedQuery REST API for bulk delete
codecov-commenter commented on pull request #10793:
URL: https://github.com/apache/incubator-superset/pull/10793#issuecomment-687130986
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10793?src=pr&el=h1) Report
> Merging [#10793](https://codecov.io/gh/apache/incubator-superset/pull/10793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5199423ad19d30ee066dcfdb75c10f9c084a1250?el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `88.75%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10793 +/- ##
==========================================
- Coverage 61.22% 61.16% -0.07%
==========================================
Files 802 806 +4
Lines 37814 37891 +77
Branches 3555 3555
==========================================
+ Hits 23153 23176 +23
- Misses 14475 14529 +54
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.60% <ø> (ø)` | |
| #python | `60.91% <88.75%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/queries/savedqueries/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZHF1ZXJpZXMvZGFvLnB5) | `80.95% <80.95%> (ø)` | |
| [...erset/queries/savedqueries/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZHF1ZXJpZXMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `88.46% <88.46%> (ø)` | |
| [superset/queries/savedqueries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZHF1ZXJpZXMvYXBpLnB5) | `95.65% <92.00%> (-4.35%)` | :arrow_down: |
| [...perset/queries/savedqueries/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZHF1ZXJpZXMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/queries/savedqueries/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZHF1ZXJpZXMvc2NoZW1hcy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.05% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.58% <0.00%> (-0.14%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/10793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10793?src=pr&el=footer). Last update [5199423...877129e](https://codecov.io/gh/apache/incubator-superset/pull/10793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org