[PR] Use the resolver's own HTTP transport in tests [maven-checkstyle-plugin]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz opened a new pull request, #681:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/681

   The test classpath carried two artifacts to give Resolver a way of speaking HTTP:
   
   ```xml
   <artifactId>maven-resolver-transport-wagon</artifactId>
   <artifactId>wagon-http-lightweight</artifactId>
   ```
   
   Resolver has had its own HTTP transport since 1.0, so `maven-resolver-transport-http` at the same `${resolverVersion}` does the same job on its own. `maven-resolver-connector-basic` stays as it is — that is the connector, not the transport.
   
   `wagon-http-lightweight` is additionally marked for removal in Wagon 4.0.0, and nothing here needs a Wagon provider in particular; it was only ever the thing on the other side of the wagon transport.
   
   **Verified:** `mvn test` gives 26 tests, 0 failures, 1 skipped both before and after.
   
   This came out of a survey of how Maven projects actually depend on Wagon. The same pattern appears in maven-project-info-reports-plugin and maven-surefire-report-plugin, which are getting the same change. It does **not** work in maven-doap-plugin, whose tests resolve through the legacy `maven-compat` `WagonManager` and so genuinely need a Wagon provider registered for `https` — that one is being left alone.
   
   The `<ignoredDependencies>` list for the dependency analysis is updated to match.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use the resolver's own HTTP transport in tests [maven-checkstyle-plugin]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz merged PR #681:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use the resolver's own HTTP transport in tests [maven-checkstyle-plugin]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz commented on PR #681:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/681#issuecomment-5226348495

   Added a second commit removing the unused `maven-compat` test dependency, and dropping it from the dependency-analysis `<ignoredDependencies>` list at the same time.
   
   Nothing in the plugin imports anything from maven-compat — the declaration had simply outlived whatever needed it, and the ignore rule was what kept the analysis quiet about it.
   
   Tests: 26, 0 failures, 1 skipped — unchanged by either commit.
   
   Kept on this branch rather than opened as a separate PR since it touches adjacent lines in the same file. Happy to split it out if you would rather review them apart.
   
   This is part of a wider survey of which projects still declare maven-compat versus which genuinely use it; several turn out never to touch it, while others depend on it in ways that are not trivially removable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org