You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/23 02:36:59 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #35285: [SPARK-37987][SS][TESTS] Print out which exception was thrown in schema validation unit test

HyukjinKwon opened a new pull request #35285:
URL: https://github.com/apache/spark/pull/35285


   ### What changes were proposed in this pull request?
   
   This PR improves the `assert` message by showing full stack trace from the exception thrown on the flaky test `StreamingAggregationSuite.changing schema of state when restarting query - state format version 1` in order to debug further why it fails.
   
   ### Why are the changes needed?
   
   To debug the cause of flakiness.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   N/A.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #35285: [SPARK-37987][SS][TESTS] Print out which exception was thrown in schema validation unit test

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35285:
URL: https://github.com/apache/spark/pull/35285


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #35285: [SPARK-37987][SS][TESTS] Print out which exception was thrown in schema validation unit test

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #35285:
URL: https://github.com/apache/spark/pull/35285#issuecomment-1020737697


   I have see this test failed about ten times in mu GA test. Yea, not so urgent. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35285: [SPARK-37987][SS][TESTS] Print out which exception was thrown in schema validation unit test

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35285:
URL: https://github.com/apache/spark/pull/35285#issuecomment-1019399925


   cc @HeartSaVioR @AngersZhuuuu. Please let me know if you guys know the cause of flakiness. Then we don't need this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35285: [SPARK-37987][SS][TESTS] Print out which exception was thrown in schema validation unit test

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35285:
URL: https://github.com/apache/spark/pull/35285#issuecomment-1019742057


   What I heard form @AngersZhuuuu was that it's pretty flaky. It's not urgent I guess. If you have an idea on the cause and how to fix, maybe we can just close this PR then :-).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HeartSaVioR commented on pull request #35285: [SPARK-37987][SS][TESTS] Print out which exception was thrown in schema validation unit test

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35285:
URL: https://github.com/apache/spark/pull/35285#issuecomment-1019661939


   Do we have a rough sense of how flaky it is? I have an idea to fix this, but we'd like to verify it though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #35285: [SPARK-37987][SS][TESTS] Print out which exception was thrown in schema validation unit test

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #35285:
URL: https://github.com/apache/spark/pull/35285#issuecomment-1020737697


   I have see this test failed about ten times in mu GA test. Yea, not so urgent. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org