You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/17 14:15:20 UTC

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8026: [IOTDB-4498] Adjust error code

MarcosZyk commented on code in PR #8026:
URL: https://github.com/apache/iotdb/pull/8026#discussion_r1025242076


##########
service-rpc/src/main/java/org/apache/iotdb/rpc/TSStatusCode.java:
##########
@@ -31,140 +31,145 @@
  */
 public enum TSStatusCode {
   SUCCESS_STATUS(200),
-  STILL_EXECUTING_STATUS(201),
-  INCOMPATIBLE_VERSION(203),
-
-  NODE_DELETE_ERROR(298),
-  ALIAS_ALREADY_EXIST(299),
-  PATH_ALREADY_EXIST(300),
-  METADATA_ERROR(303),
-  PATH_NOT_EXIST(304),
-  OUT_OF_TTL(305),
-  COMPACTION_ERROR(307),
-  SYSTEM_CHECK_ERROR(308),
-  SYNC_CONNECTION_ERROR(310),
-  DATABASE_PROCESS_ERROR(311),
-  STORAGE_ENGINE_ERROR(313),
-  TSFILE_PROCESSOR_ERROR(314),
-  PATH_ILLEGAL(315),
-  LOAD_FILE_ERROR(316),
-  DATABASE_NOT_READY(317),
-  ILLEGAL_PARAMETER(318),
-  ALIGNED_TIMESERIES_ERROR(319),
-  DUPLICATED_TEMPLATE(320),
-  UNDEFINED_TEMPLATE(321),
-  DATABASE_NOT_EXIST(322),
-  CONTINUOUS_QUERY_ERROR(323),
-  TEMPLATE_NOT_SET(324),
-  DIFFERENT_TEMPLATE(325),
-  TEMPLATE_IS_IN_USE(326),
-  TEMPLATE_INCOMPATIBLE(327),
-  SEGMENT_NOT_FOUND(328),
-  PAGE_OUT_OF_SPACE(329),
-  RECORD_DUPLICATED(330),
-  SEGMENT_OUT_OF_SPACE(331),
-  SCHEMA_FILE_NOT_EXISTS(332),
-  WRITE_AHEAD_LOG_ERROR(333),
-  CREATE_PIPE_SINK_ERROR(334),
-  PIPE_ERROR(335),
-  PIPESERVER_ERROR(336),
-  SERIES_OVERFLOW(337),
-  TIMESERIES_ALREADY_EXIST(338),
-  CREATE_TEMPLATE_ERROR(340),
-  SYNC_FILE_REDIRECTION_ERROR(341),
-  SYNC_FILE_ERROR(342),
-  VERIFY_METADATA_ERROR(343),
-  TIMESERIES_IN_BLACK_LIST(344),
-  OVERSIZE_RECORD(349),
-  SCHEMA_FILE_REDO_LOG_BROKEN(350),
-  TRIGGER_FIRE_ERROR(355),
-  TRIGGER_LOAD_CLASS_ERROR(360),
-  TRIGGER_DOWNLOAD_ERROR(361),
-  CREATE_TRIGGER_INSTANCE_ERROR(362),
-  ACTIVE_TRIGGER_INSTANCE_ERROR(363),
-  DROP_TRIGGER_INSTANCE_ERROR(364),
-  UPDATE_TRIGGER_LOCATION_ERROR(365),
-  TEMPLATE_NOT_ACTIVATED(366),
-
-  UDF_LOAD_CLASS_ERROR(370),
-  UDF_DOWNLOAD_ERROR(371),
-  CREATE_FUNCTION_ON_DATANODE_ERROR(372),
-  DROP_FUNCTION_ON_DATANODE_ERROR(373),
-
-  EXECUTE_STATEMENT_ERROR(400),
-  SQL_PARSE_ERROR(401),
-  GENERATE_TIME_ZONE_ERROR(402),
-  SET_TIME_ZONE_ERROR(403),
-  QUERY_NOT_ALLOWED(405),
-  LOGICAL_OPERATOR_ERROR(407),
-  LOGICAL_OPTIMIZE_ERROR(408),
-  UNSUPPORTED_FILL_TYPE(409),
-  QUERY_PROCESS_ERROR(411),
-  WRITE_PROCESS_ERROR(412),
-  WRITE_PROCESS_REJECT(413),
-  SEMANTIC_ERROR(416),
-  LOAD_PIECE_OF_TSFILE_ERROR(417),
-
-  UNSUPPORTED_INDEX_TYPE(422),
-
-  MEMORY_NOT_ENOUGH(423),
-
-  INTERNAL_SERVER_ERROR(500),
-  CLOSE_OPERATION_ERROR(501),
-  READ_ONLY_SYSTEM(502),
-  DISK_SPACE_INSUFFICIENT(503),
-  START_UP_ERROR(504),
-  SHUT_DOWN_ERROR(505),
-  MULTIPLE_ERROR(506),
-  TSBLOCK_SERIALIZE_ERROR(508),
-
-  WRONG_LOGIN_PASSWORD(600),
-  NOT_LOGIN(601),
-  NO_PERMISSION(602),
-  UNINITIALIZED_AUTH_ERROR(603),
-  EXECUTE_PERMISSION_ERROR(604),
-  USER_NOT_EXIST(605),
-  ROLE_NOT_EXIST(606),
-  AUTHENTICATION_FAILED(607),
-  CLEAR_PERMISSION_CACHE_ERROR(608),
-
-  // cluster-related errors
-  TIME_OUT(701),
-  UNSUPPORTED_OPERATION(703),
-  NO_CONNECTION(706),
-  NEED_REDIRECTION(707),
-  ALL_RETRY_ERROR(709),
-  MIGRATE_REGION_ERROR(710),
-  CREATE_REGION_ERROR(711),
-  DELETE_REGION_ERROR(712),
-  PARTITION_CACHE_UPDATE_ERROR(713),
-  DESERIALIZE_PIECE_OF_TSFILE_ERROR(714),
-  CONSENSUS_NOT_INITIALIZED(715),
-
-  // configuration
-  CONFIGURATION_ERROR(800),
-
-  // ConfigNode response
-  DATANODE_ALREADY_REGISTERED(901),
-  DATABASE_ALREADY_EXISTS(903),
-  NO_ENOUGH_DATANODE(904),
-  ERROR_GLOBAL_CONFIG(905),
-  ADD_CONFIGNODE_ERROR(906),
-  REMOVE_CONFIGNODE_ERROR(907),
-  DATANODE_NOT_EXIST(912),
-  DATANODE_STOP_ERROR(917),
-  REGION_LEADER_CHANGE_ERROR(918),
-  REMOVE_DATANODE_ERROR(919),
-  OVERLAP_WITH_EXISTING_TASK(920),
-  NOT_AVAILABLE_REGION_GROUP(921),
-  CREATE_TRIGGER_ERROR(922),
-  DROP_TRIGGER_ERROR(923),
-  REGISTER_REMOVED_DATANODE(925),
-
-  NO_SUCH_CQ(930),
-  CQ_ALREADY_ACTIVE(931),
-  CQ_AlREADY_EXIST(932),
-  CQ_UPDATE_LAST_EXEC_TIME_ERROR(933);
+
+  // System level
+  INCOMPATIBLE_VERSION(201),
+  CONFIGURATION_ERROR(202),
+  START_UP_ERROR(203),
+  SHUT_DOWN_ERROR(204),
+
+  // General Error
+  UNSUPPORTED_OPERATION(300),
+  EXECUTE_STATEMENT_ERROR(301),
+  MULTIPLE_ERROR(302),
+  ILLEGAL_PARAMETER(303),
+  OVERLAP_WITH_EXISTING_TASK(304),
+  INTERNAL_SERVER_ERROR(305),
+
+  // Client,
+  REDIRECTION_RECOMMEND(400),
+
+  // Schema Engine
+  DATABASE_NOT_EXIST(500),
+  DATABASE_ALREADY_EXISTS(501),
+  SERIES_OVERFLOW(502),
+  TIMESERIES_ALREADY_EXIST(503),
+  TIMESERIES_IN_BLACK_LIST(504),
+  ALIAS_ALREADY_EXIST(505),
+  PATH_ALREADY_EXIST(506),
+  METADATA_ERROR(507),
+  PATH_NOT_EXIST(508),
+  ILLEGAL_PATH(509),
+  CREATE_TEMPLATE_ERROR(510),
+  DUPLICATED_TEMPLATE(511),
+  UNDEFINED_TEMPLATE(512),
+  TEMPLATE_NOT_SET(513),
+  DIFFERENT_TEMPLATE(514),
+  TEMPLATE_IS_IN_USE(515),
+  TEMPLATE_INCOMPATIBLE(516),
+  SEGMENT_NOT_FOUND(517),
+  PAGE_OUT_OF_SPACE(518),
+  RECORD_DUPLICATED(519),
+  SEGMENT_OUT_OF_SPACE(520),
+  SCHEMA_FILE_NOT_EXISTS(521),
+  OVERSIZE_RECORD(522),
+  SCHEMA_FILE_REDO_LOG_BROKEN(523),
+  TEMPLATE_NOT_ACTIVATED(524),
+
+  // Storage Engine
+  SYSTEM_READ_ONLY(600),
+  STORAGE_ENGINE_ERROR(601),
+  STORAGE_ENGINE_NOT_READY(602),
+  DATAREGION_PROCESS_ERROR(603),
+  TSFILE_PROCESSOR_ERROR(604),
+  WRITE_PROCESS_ERROR(605),
+  WRITE_PROCESS_REJECT(606),
+  OUT_OF_TTL(607),
+  COMPACTION_ERROR(608),
+  ALIGNED_TIMESERIES_ERROR(609),
+  WAL_ERROR(610),
+  DISK_SPACE_INSUFFICIENT(611),
+
+  // Query Engine
+  SQL_PARSE_ERROR(700),
+  SEMANTIC_ERROR(701),
+  GENERATE_TIME_ZONE_ERROR(702),
+  SET_TIME_ZONE_ERROR(703),
+  QUERY_NOT_ALLOWED(704),
+  LOGICAL_OPERATOR_ERROR(705),
+  LOGICAL_OPTIMIZE_ERROR(706),
+  UNSUPPORTED_FILL_TYPE(707),
+  QUERY_PROCESS_ERROR(708),
+  MPP_MEMORY_NOT_ENOUGH(709),
+  CLOSE_OPERATION_ERROR(710),
+  TSBLOCK_SERIALIZE_ERROR(711),
+  INTERNAL_REQUEST_TIME_OUT(712),
+  INTERNAL_REQUEST_RETRY_ERROR(713),
+
+  // Authentication
+  AUTHENTICATION_ERROR(800),
+  WRONG_LOGIN_PASSWORD(801),
+  NOT_LOGIN(802),
+  NO_PERMISSION(803),
+  UNINITIALIZED_AUTH_ERROR(804),
+  USER_NOT_EXIST(805),
+  ROLE_NOT_EXIST(806),
+  CLEAR_PERMISSION_CACHE_ERROR(807),
+
+  // Partition Error
+  MIGRATE_REGION_ERROR(900),
+  CREATE_REGION_ERROR(901),
+  DELETE_REGION_ERROR(902),
+  PARTITION_CACHE_UPDATE_ERROR(903),
+  CONSENSUS_NOT_INITIALIZED(904),
+  REGION_LEADER_CHANGE_ERROR(905),
+  NO_AVAILABLE_REGION_GROUP(906),
+
+  // Cluster Manager
+  ADD_CONFIGNODE_ERROR(1000),
+  REMOVE_CONFIGNODE_ERROR(1001),
+  DATANODE_ALREADY_REGISTERED(1002),
+  NO_ENOUGH_DATANODE(1003),
+  DATANODE_NOT_EXIST(1004),

Review Comment:
   Is this duplicated with ```DATABASE_NOT_EXIST(500)```?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org