You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2023/03/01 22:24:10 UTC
[GitHub] [solr] janhoy opened a new pull request, #1413: SOLR-16683 Fix frequent failures of OtelTracerConfiguratorTest
janhoy opened a new pull request, #1413:
URL: https://github.com/apache/solr/pull/1413
https://issues.apache.org/jira/browse/SOLR-16683
The `@ThreadLeakLingering` should be in millis, not seconds, so 10 means 10ms, but we should wait for 10s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1413: SOLR-16683 Fix frequent failures of OtelTracerConfiguratorTest
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #1413:
URL: https://github.com/apache/solr/pull/1413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1413: SOLR-16683 Fix frequent failures of OtelTracerConfiguratorTest
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #1413:
URL: https://github.com/apache/solr/pull/1413#issuecomment-1451090615
I haven't tried these changes, but its sad that the worker thread is just unmanaged and can't be shutdown.
https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessor.java#L85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1413: SOLR-16683 Fix frequent failures of OtelTracerConfiguratorTest
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1413:
URL: https://github.com/apache/solr/pull/1413#issuecomment-1452270624
> I haven't tried these changes, but its sad that the worker thread is just unmanaged and can't be shutdown.
Yes, they should allow passing in an executor or otherwise control it. But Hopefully the timeouts set in the test will now cause the worker to shutdown within 10s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org