You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by an...@apache.org on 2016/11/22 03:27:23 UTC
[03/13] mesos git commit: Removed extraneous socket argument from
`DataDecoder` constructor.
Removed extraneous socket argument from `DataDecoder` constructor.
This argument is not used anywhere in the code. This makes it
consistent with the streaming request decoder.
Review: https://reviews.apache.org/r/53510/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/dceacc50
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/dceacc50
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/dceacc50
Branch: refs/heads/master
Commit: dceacc50ce8577b1d0fd5cde0e55dadef1907fdf
Parents: 32e203e
Author: Anand Mazumdar <an...@apache.org>
Authored: Mon Nov 21 18:07:47 2016 -0800
Committer: Anand Mazumdar <an...@apache.org>
Committed: Mon Nov 21 19:27:08 2016 -0800
----------------------------------------------------------------------
3rdparty/libprocess/src/decoder.hpp | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/dceacc50/3rdparty/libprocess/src/decoder.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/decoder.hpp b/3rdparty/libprocess/src/decoder.hpp
index 88ef1d1..13db2ee 100644
--- a/3rdparty/libprocess/src/decoder.hpp
+++ b/3rdparty/libprocess/src/decoder.hpp
@@ -23,7 +23,6 @@
#include <vector>
#include <process/http.hpp>
-#include <process/socket.hpp>
#include <stout/foreach.hpp>
#include <stout/gzip.hpp>
@@ -43,8 +42,8 @@ namespace process {
class DataDecoder
{
public:
- explicit DataDecoder(const network::Socket& _s)
- : s(_s), failure(false), request(nullptr)
+ DataDecoder()
+ : failure(false), request(nullptr)
{
settings.on_message_begin = &DataDecoder::on_message_begin;
settings.on_url = &DataDecoder::on_url;
@@ -93,11 +92,6 @@ public:
return failure;
}
- network::Socket socket() const
- {
- return s;
- }
-
private:
static int on_message_begin(http_parser* p)
{
@@ -262,8 +256,6 @@ private:
return 0;
}
- const network::Socket s; // The socket this decoder is associated with.
-
bool failure;
http_parser parser;