You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/16 16:44:24 UTC
[GitHub] [flink] walterddr commented on a change in pull request #8186: [FLINK-12198] Flink JDBC Connector: Update existing JDBCInputFormat t…
walterddr commented on a change in pull request #8186: [FLINK-12198] Flink JDBC Connector: Update existing JDBCInputFormat t…
URL: https://github.com/apache/flink/pull/8186#discussion_r275889475
##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
##########
@@ -154,6 +154,63 @@ public void testFetchSizeCanBeConfigured() throws SQLException {
Assert.assertEquals(desiredFetchSize, jdbcInputFormat.getStatement().getFetchSize());
}
+ @Test
+ public void testAutoCommitFalse() {
Review comment:
I am not sure this is needed, unlike setFetchSize, there's no Precondition.check in setAutoCommit, maybe just combine these with the last test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services