You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/24 09:59:33 UTC
[GitHub] [rocketmq] 15712852007 opened a new pull request, #4881: send async,time calculation rules Multiple method patches
15712852007 opened a new pull request, #4881:
URL: https://github.com/apache/rocketmq/pull/4881
For issues that were closed yesterday, there are still some missing methods. Please try merging again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on pull request #4881: send async,time calculation rules Multiple method patches
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #4881:
URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1228084405
Hi, think you for contributing!
You may need to rebase the develop branch to pass the residual status check because we re-defined the mergeability recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] 15712852007 commented on pull request #4881: send async,time calculation rules Multiple method patches
Posted by GitBox <gi...@apache.org>.
15712852007 commented on PR #4881:
URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1225502609
@lizhanhui Please help to merge again, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4881: send async,time calculation rules Multiple method patches
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4881:
URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1228190203
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4881?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4881](https://codecov.io/gh/apache/rocketmq/pull/4881?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb12805) into [develop](https://codecov.io/gh/apache/rocketmq/commit/c4117138367234d6cfbddcbac733ef1c34ab0aa3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c411713) will **decrease** coverage by `0.00%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## develop #4881 +/- ##
=============================================
- Coverage 43.29% 43.29% -0.01%
+ Complexity 7688 7686 -2
=============================================
Files 991 991
Lines 68784 68776 -8
Branches 9112 9110 -2
=============================================
- Hits 29779 29775 -4
+ Misses 35263 35251 -12
- Partials 3742 3750 +8
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | `44.29% <50.00%> (-0.06%)` | :arrow_down: |
| [...etmq/namesrv/routeinfo/BatchUnRegisterService.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vQmF0Y2hVblJlZ2lzdGVyU2VydmljZS5qYXZh) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
| [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | :arrow_down: |
| [...mq/store/ha/autoswitch/AutoSwitchHAConnection.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvQXV0b1N3aXRjaEhBQ29ubmVjdGlvbi5qYXZh) | `73.29% <0.00%> (-1.64%)` | :arrow_down: |
| [...apache/rocketmq/store/queue/BatchConsumeQueue.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL0JhdGNoQ29uc3VtZVF1ZXVlLmphdmE=) | `69.50% <0.00%> (-0.63%)` | :arrow_down: |
| [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `43.73% <0.00%> (-0.44%)` | :arrow_down: |
| [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `47.30% <0.00%> (-0.14%)` | :arrow_down: |
| [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (ø)` | |
| [...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==) | `81.25% <0.00%> (ø)` | |
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `49.72% <0.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/rocketmq/pull/4881/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] 15712852007 commented on pull request #4881: send async,time calculation rules Multiple method patches
Posted by GitBox <gi...@apache.org>.
15712852007 commented on PR #4881:
URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1228312867
> Hi, think you for contributing!
>
> You may need to rebase the develop branch to pass the residual status check because we re-defined the mergeability recently.
The check have been passed, please help merge the branches, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] 15712852007 commented on pull request #4881: send async,time calculation rules Multiple method patches
Posted by GitBox <gi...@apache.org>.
15712852007 commented on PR #4881:
URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1226703029
> @15712852007 It would be nice if you describe _smaller and more reasonable designs based on the current version_ in finer detail.
@lizhanhui In my opinion, there are two main areas where the client takes the most time to send messages:
1. The thread is waiting to be scheduled.
2. Network request correlation,
As a user, I care more about the timeout of the program during running, rather than the timeout of the program before it starts running. In my opinion, it is the best choice to eliminate the time consuming before the program runs, because complex solutions often cause performance loss, so it is not as practical as simple solutions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] 15712852007 commented on pull request #4881: send async,time calculation rules Multiple method patches
Posted by GitBox <gi...@apache.org>.
15712852007 commented on PR #4881:
URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1226663708
> @15712852007 1, The synchronous path shall also be updated; 2, For async method, we should have a timer, helping to respect timeout specified by the method. For the async send, its workflow should be
>
> 1. client call async method;
> 2. create a timeout timer;
> 3. invoke async rpc; perform transparent retries if timeout is not reached;
> 4. if RPC is successful within time frame, cancel the timer; if timeout timer fires, call callback with timeout;
In my opinion, the introduction of timers may cause unnecessary waste of resources and may cause performance problems, we can make smaller and more reasonable designs based on the current version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #4881: send async,time calculation rules Multiple method patches
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4881:
URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1225578809
@15712852007 1, The synchronous path shall also be updated; 2, For async method, we should have a timer, helping to respect timeout specified by the method.
For the async send, its workflow should be
1. client call async method;
2. create a timeout timer;
3. invoke async rpc; perform transparent retries if timeout is not reached;
4. if RPC is successful within time frame, cancel the timer; if timeout timer fires, call callback with timeout;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #4881: send async,time calculation rules Multiple method patches
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4881:
URL: https://github.com/apache/rocketmq/pull/4881#issuecomment-1226687079
@15712852007 It would be nice if you describe *smaller and more reasonable designs based on the current version* in finer detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui merged pull request #4881: send async,time calculation rules Multiple method patches
Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #4881:
URL: https://github.com/apache/rocketmq/pull/4881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org