[GitHub] ccollins476ad opened a new pull request #73: syscfg - Only apply conditional overrides if condition is true

[gi...@git.apache.org]

ccollins476ad opened a new pull request #73: syscfg - Only apply conditional overrides if condition is true
URL: https://github.com/apache/incubator-mynewt-newt/pull/73
 
 
   This commit fixes a bug involving conditional overrides of syscfg
   values.  In the following syscfg listing:
   
       syscfg.vals.MY_SETTING:
           LOG_LEVEL: 255
   
   LOG_LEVEL should only get set to 255 if MY_SETTING is defined with a
   true value (nonzero and non-empty-string).  However, the actual behavior
   is that LOG_LEVEL gets overridden if MY_SETTING is defined at all,
   regardless of its value.
   
   The fix is to only apply the override if the condition is true.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services