You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2026/06/18 23:26:18 UTC

[PR] chore: fix `ConstantFolding` rule exclusion [datafusion-comet]

comphead opened a new pull request, #4689:
URL: https://github.com/apache/datafusion-comet/pull/4689

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #4656 .
   
   ## Rationale for this change
   
   Three Comet benchmark files set `spark.sql.optimizer.constantFolding.enabled = false`, but **this Spark config does not exist** - it is silently ignored, so constant folding has been running during these benchmarks the whole time.
   
    Spark has no per-rule on/off flag for `ConstantFolding`. The canonical way to disable an individual Catalyst rule `spark.sql.optimizer.excludedRules`, which takes a comma-separated list of fully-qualified rule class names (see `SQLConf.OPTIMIZER_EXCLUDED_RULES`). The rest of the Comet test suite (`CometExpressionSuite`,`CometStringExpressionSuite`, `CometArrayExpressionSuite`,`CometSqlFileTestSuite`, etc.) already uses this pattern.
   
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## How are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] chore: fix `ConstantFolding` rule exclusion for benchmarks [datafusion-comet]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #4689:
URL: https://github.com/apache/datafusion-comet/pull/4689


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org