You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/22 06:55:56 UTC
[GitHub] [pulsar] yuruguo opened a new pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
yuruguo opened a new pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128
### Motivation
The value of option `--forward-source-message-property` is true by default, but it cannot be set to false, which means that we cannot prevent the input message's properties from being forwarded to the output topic.
The problem is that JCommander doesn't expect arguments to boolean parameters by default.
This is explained in the JCommander manual and issue comment cbeust/jcommander#129 (comment) .
### Modifications
- add arity = 1 to the JCommander Parameter annotation.
JCommander requires specifying arity = 1 to boolean parameters that have a default value of true.
### Documentation
- `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-931215106
@k2la PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-932832179
@merlimat @lhotari @eolivelli @aahmed-se @k2la - PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-942803396
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL. And if there is no problem, please merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-930643144
@merlimat @lhotari @aahmed-se @eolivelli @codelipenghui @BewareMyPower @hangc0276 @gaoran10 - PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-941851435
@merlimat @lhotari @eolivelli @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-929716985
@merlimat @lhotari @eolivelli @codelipenghui @BewareMyPower @hangc0276 @MarvinCai PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-925405576
PTAL @merlimat @lhotari @eolivelli @codelipenghui @BewareMyPower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-940628727
@merlimat @lhotari @eolivelli @315157973 @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927204910
PTAL @merlimat @lhotari @eolivelli @codelipenghui @gaoran10 @MarvinCai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-925429523
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @BewareMyPower PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on a change in pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on a change in pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#discussion_r714026749
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -271,7 +271,7 @@ void processArguments() throws Exception {
protected Boolean retainKeyOrdering;
@Parameter(names = "--batch-builder", description = "BatcherBuilder provides two types of batch construction methods, DEFAULT and KEY_BASED. The default value is: DEFAULT")
protected String batchBuilder;
- @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing")
+ @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing", arity = 1)
Review comment:
can we update the doc to reflect the change, like `to disable it use --forward-source-message-property false`?
as user usually won't expect to provide parameter for a `flag`
also please rebase on latest master once this [pr](https://github.com/apache/pulsar/pull/12134) is merged, current CI is broken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927395986
@merlimat @lhotari @eolivelli @codelipenghui @gaoran10 @MarvinCai PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-928425632
@merlimat @lhotari @eolivelli @codelipenghui @hangc0276 @MarvinCai PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-931215106
@k2la PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927395986
@merlimat @lhotari @eolivelli @codelipenghui @gaoran10 @MarvinCai PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-937322993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-928425632
@merlimat @lhotari @eolivelli @codelipenghui @hangc0276 @MarvinCai PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-934132452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-939578360
@aahmed-se @eolivelli @k2la PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927395986
@merlimat @lhotari @eolivelli @codelipenghui @gaoran10 @MarvinCai PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-925405576
PTAL @merlimat @lhotari @eolivelli @codelipenghui @BewareMyPower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-928425632
@merlimat @lhotari @eolivelli @codelipenghui @hangc0276 @MarvinCai PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-930643144
@merlimat @lhotari @aahmed-se @eolivelli @codelipenghui @BewareMyPower @hangc0276 - PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-925429523
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @BewareMyPower PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-924676736
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927204910
PTAL @merlimat @lhotari @eolivelli @codelipenghui @gaoran10 @MarvinCai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-938327510
@freeznet @nlu90 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-932832179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-933039717
@merlimat @lhotari @eolivelli @aahmed-se @k2la - PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-939188308
@merlimat @lhotari @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-939188308
@merlimat @lhotari @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-938218910
@merlimat @lhotari @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-940628727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-930809536
@merlimat @lhotari @eolivelli @aahmed-se @codelipenghui @BewareMyPower @hangc0276 @gaoran10 - PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-934132452
@merlimat @lhotari @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-934132452
@merlimat @lhotari @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-940628727
@merlimat @lhotari @eolivelli @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-938327510
@freeznet @nlu90 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-942424414
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL. And if there is no problem, please merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-933039717
@merlimat @lhotari @eolivelli @aahmed-se @k2la - PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-924883923
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-937322993
@merlimat @lhotari @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-942424414
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL. And if there is no problem, please merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-925110488
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927204910
PTAL @merlimat @lhotari @eolivelli @gaoran10 @MarvinCai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#discussion_r714379146
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -271,7 +271,7 @@ void processArguments() throws Exception {
protected Boolean retainKeyOrdering;
@Parameter(names = "--batch-builder", description = "BatcherBuilder provides two types of batch construction methods, DEFAULT and KEY_BASED. The default value is: DEFAULT")
protected String batchBuilder;
- @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing")
+ @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing", arity = 1)
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-924883923
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-924676736
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-941851435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-929716985
@merlimat @lhotari @eolivelli @codelipenghui @BewareMyPower @hangc0276 @MarvinCai PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#discussion_r714379146
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -271,7 +271,7 @@ void processArguments() throws Exception {
protected Boolean retainKeyOrdering;
@Parameter(names = "--batch-builder", description = "BatcherBuilder provides two types of batch construction methods, DEFAULT and KEY_BASED. The default value is: DEFAULT")
protected String batchBuilder;
- @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing")
+ @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing", arity = 1)
Review comment:
done, PTAL @MarvinCai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927204910
PTAL @lhotari @eolivelli @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-942803396
@merlimat @lhotari @eolivelli @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL. And if there is no problem, please merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-925408258
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-929716985
@merlimat @lhotari @eolivelli @codelipenghui @BewareMyPower @hangc0276 @MarvinCai PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-930643144
@merlimat @lhotari @aahmed-se @eolivelli @codelipenghui @BewareMyPower @hangc0276 @gaoran10 - PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-925110488
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-928425632
@merlimat @lhotari @eolivelli @codelipenghui @hangc0276 @MarvinCai PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-940628727
@merlimat @lhotari @eolivelli @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-939578360
@aahmed-se @eolivelli @k2la PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-934132452
@merlimat @lhotari @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @BewareMyPower @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-925408258
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on a change in pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on a change in pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#discussion_r714026749
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -271,7 +271,7 @@ void processArguments() throws Exception {
protected Boolean retainKeyOrdering;
@Parameter(names = "--batch-builder", description = "BatcherBuilder provides two types of batch construction methods, DEFAULT and KEY_BASED. The default value is: DEFAULT")
protected String batchBuilder;
- @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing")
+ @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing", arity = 1)
Review comment:
can we update the doc to reflect the change, like `to disable it use --forward-source-message-property false`?
as user usually won't expect to provide parameter for a `flag`
also please rebase on latest master, there's a fix on CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org