You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackylee-ch (via GitHub)" <gi...@apache.org> on 2026/09/07 07:16:37 UTC

[PR] Flink: Fix microsecond truncation for timestamps in arrays and maps [iceberg]

jackylee-ch opened a new pull request, #18001:
URL: https://github.com/apache/iceberg/pull/18001

   The nano-of-millisecond argument in `StructRowData.convertValue` is `floorMod(timeMillis * 1000, 1000) * 1000`, always 0 since `timeMillis` is already millis. A `timestamp` in an array or map loses sub-millisecond precision: `12:00:00.123456` reads back as `12:00:00.123`. Normalized to micros first, like `TIMESTAMP_NANO` below it.
   
   ### Testing
   
   `iceberg-flink-{1.20,2.1,2.2,2.3}:test --tests TestStructRowData`
   
   ---
   **AI Disclosure**
   - Model: Claude Opus 5
   - Platform/Tool: Ducc
   - Human Oversight: fully reviewed
   - Prompt Summary: Fix microsecond truncation for nested timestamps.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Flink: Fix microsecond truncation for timestamps in arrays and maps [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #18001:
URL: https://github.com/apache/iceberg/pull/18001#issuecomment-5568449438

   Merged to main.
   Thanks @jackylee-ch for catching this. CC: @talatuyarer 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Flink: Fix microsecond truncation for timestamps in arrays and maps [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #18001:
URL: https://github.com/apache/iceberg/pull/18001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org