You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Supreeth Sharma <su...@gmail.com> on 2017/04/20 12:01:46 UTC
Review Request 58564: Need to change the arrangement of the action
buttons in project manager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58564/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20800
https://issues.apache.org/jira/browse/AMBARI-20800
Repository: ambari
Description
-------
Rearranged the Delete and Close buttons so as to keep the styling consistent.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs ac28de3
Diff: https://reviews.apache.org/r/58564/diff/1/
Testing
-------
Manual testing done
Thanks,
Supreeth Sharma
Re: Review Request 58564: Need to change the arrangement of the action
buttons in project manager
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58564/#review172475
-----------------------------------------------------------
Ship it!
Ship It!
- venkat sairam
On April 20, 2017, 12:01 p.m., Supreeth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58564/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 12:01 p.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20800
> https://issues.apache.org/jira/browse/AMBARI-20800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rearranged the Delete and Close buttons so as to keep the styling consistent.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs ac28de3
>
>
> Diff: https://reviews.apache.org/r/58564/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Supreeth Sharma
>
>
Re: Review Request 58564: Need to change the arrangement of the action
buttons in project manager
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58564/#review172609
-----------------------------------------------------------
Ship it!
Ship It!
- Padma Priya N
On April 20, 2017, 12:01 p.m., Supreeth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58564/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 12:01 p.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20800
> https://issues.apache.org/jira/browse/AMBARI-20800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rearranged the Delete and Close buttons so as to keep the styling consistent.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs ac28de3
>
>
> Diff: https://reviews.apache.org/r/58564/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Supreeth Sharma
>
>
Re: Review Request 58564: Need to change the arrangement of the action
buttons in project manager
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58564/#review172484
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On April 20, 2017, 12:01 p.m., Supreeth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58564/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 12:01 p.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20800
> https://issues.apache.org/jira/browse/AMBARI-20800
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Rearranged the Delete and Close buttons so as to keep the styling consistent.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs ac28de3
>
>
> Diff: https://reviews.apache.org/r/58564/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Supreeth Sharma
>
>