You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/11/24 01:42:53 UTC

[GitHub] [incubator-brpc] gydong commented on a change in pull request #1291: make butil::ScopedVector support std::initializer_list

gydong commented on a change in pull request #1291:
URL: https://github.com/apache/incubator-brpc/pull/1291#discussion_r529113569



##########
File path: src/butil/memory/scoped_vector.h
##########
@@ -38,6 +41,9 @@ class ScopedVector {
   ScopedVector() {}
   ~ScopedVector() { clear(); }
   ScopedVector(RValue other) { swap(*other.object); }
+#if __cplusplus >= 201103L  // < C++11

Review comment:
       >= c++11 
     or just delete this comment since the statement is self-descriptive enough.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org