You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/02 09:00:22 UTC

[GitHub] [iotdb] jixuan1989 commented on pull request #2597: [IOTDB-1140] [IOTDB-1125] optimize regular data encoding

jixuan1989 commented on pull request #2597:
URL: https://github.com/apache/iotdb/pull/2597#issuecomment-771479247


   Hi, Current description of the PR is clear.
   But IMO,  the `regular` encoding is more suitable for the timestamp column... how do you think? (is there some cases that the value column obeys the pattern?)
   
   
   > sample: 1000，1100，1800，1400，1500...
   > current algorithm be do not use...
   > 1800 is a error point, we should identity error point, revise data.
   > revise data should be : 1000，1100，1300，1400，1500
   
   This is ... dangerous, as we modify the raw data directly and do not tell the user in time. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org