You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/30 15:48:31 UTC

[GitHub] [pulsar] sijie opened a new issue #8171: AutoRecovery should respect to the ensemble policy used in Pulsar

sijie opened a new issue #8171:
URL: https://github.com/apache/pulsar/issues/8171


   *Motivation*
   
   Pulsar uses an ensemble policy to select an ensemble to place the data. We need to configure AutoRecovery to respect to the ensemble policy used in Pulsar.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on issue #8171: AutoRecovery should respect to the ensemble policy used in Pulsar

Posted by GitBox <gi...@apache.org>.
sijie commented on issue #8171:
URL: https://github.com/apache/pulsar/issues/8171#issuecomment-703922378


   @hangc0276 This issue is not about the code. BookKeeper has the abstracted logic to find a bookie to replace when changing ensembles. The most important thing here is to ensure AutoRecovery is configured to use the same ensemble placement policy as brokers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie closed issue #8171: AutoRecovery should respect to the ensemble policy used in Pulsar

Posted by GitBox <gi...@apache.org>.
sijie closed issue #8171:
URL: https://github.com/apache/pulsar/issues/8171


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 commented on issue #8171: AutoRecovery should respect to the ensemble policy used in Pulsar

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on issue #8171:
URL: https://github.com/apache/pulsar/issues/8171#issuecomment-703347006


   I checked bookkeeper autoRecovery logic, it respected to the ensemble policy store in ledgerMetadata for each ledger fragment. The code as follow. `BookKeeperAdmin#getReplacementBookiesByIndexes`
   ```java
   EnsemblePlacementPolicy.PlacementResult<BookieSocketAddress> replaceBookieResponse =
                       bkc.getPlacementPolicy().replaceBookie(
                               lh.getLedgerMetadata().getEnsembleSize(),
                               lh.getLedgerMetadata().getWriteQuorumSize(),
                               lh.getLedgerMetadata().getAckQuorumSize(),
                               lh.getLedgerMetadata().getCustomMetadata(),
                               ensemble,
                               oldBookie,
                               bookiesToExclude);
   ```
   I am a little confused for this issue, would you please give more details. @sijie 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org