You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/09/04 14:15:21 UTC
Re: Review Request 61536: Added network ports isolator socket
utilities tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61536/#review184490
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/ports_isolator_tests.cpp
Lines 45 (patched)
<https://reviews.apache.org/r/61536/#comment260661>
Please add a comment to describe the purpose of this test.
- Qian Zhang
On Aug. 18, 2017, 1:34 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61536/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 1:34 a.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some basic tests for the network ports isolator socket
> utilities. We test that we can enumerate our own sockets and
> use that to figure out what ports we are listening on.
>
>
> Diffs
> -----
>
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
> src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61536/diff/5/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>