[GitHub] [arrow] nealrichardson commented on a change in pull request #10404: ARROW-12876: [R] Fix build flags on Raspberry Pi

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #10404:
URL: https://github.com/apache/arrow/pull/10404#discussion_r639782382



##########
File path: r/configure
##########
@@ -44,6 +44,7 @@ NOT_CRAN=`echo $NOT_CRAN | tr '[:upper:]' '[:lower:]'`
 
 VERSION=`grep '^Version' DESCRIPTION | sed s/Version:\ //`
 UNAME=`uname -s`
+DISTID=`grep ^ID\= /etc/os-release | awk -F= '{print $2}' | sed 's/\"//g'`

Review comment:
       I don't think you need to define this (esp. if you take my suggestion below)
   
   ```suggestion
   ```

##########
File path: r/configure
##########
@@ -185,6 +186,11 @@ else
   fi
 fi
 
+# If on Raspberry Pi, need to manually link against latomic
+if [ "$DISTID" = "raspbian" ]; then

Review comment:
       I think this works and is simpler (please verify)
   
   ```suggestion
   if grep raspbian /etc/os-release >/dev/null 2>&1; then
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org